Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2931953002: [Payments] Rename openWindowForClients and openWindowForPaymentHandler (Closed)
Patch Set: address nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index a640e770605d083bca3405f2fa66e7b06c93e73d..3509832f2d0008feb2330842fcd1d891a13b6e86 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -272,12 +272,11 @@ class WebServiceWorkerContextClient {
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void OpenWindowForClients(
- const WebURL&,
- std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
+ virtual void OpenNewTab(const WebURL&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
- // Similar like OpenWindowForClients above.
- virtual void OpenWindowForPaymentHandler(
+ // Similar to OpenNewTab above.
+ virtual void OpenNewPopup(
const WebURL&,
std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698