Add metrics for new CBD dialog

Add metrics for new CBD dialog

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120
Review-Url: https://codereview.chromium.org/2927063002
Cr-Commit-Position: refs/heads/master@{#478602}
Committed: https://chromium.googlesource.com/chromium/src/+/412ef84048d767626e0d95ad2c14fd3f43398eff

[dullweber, 2017-06-08 14:26:24]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 14:26:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-08 14:55:31]

Patchset #1 (id:1) has been deleted

[dullweber, 2017-06-08 14:55:36]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 14:55:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-08 14:57:57]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org

[dullweber, 2017-06-08 14:57:58]

Hi Martin, 
I added metrics for the selected tab and time range changes. Please take a look.

[dullweber, 2017-06-08 15:39:01]

Description was changed from

==========
Add metrics for new CBD dialog

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two versions of
ClearBrowsingDataPreferences.

BUG=731120
==========

to

==========
Add metrics for new CBD dialog

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120
==========

[commit-bot: I haz the power, 2017-06-08 16:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 16:27:20]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-06-09 08:19:21]

dullweber@chromium.org changed reviewers:
+ bauerb@chromium.org

[dullweber, 2017-06-09 08:19:22]

bauerb@chromium.org: Please review changes in chrome/android/ and
chrome/browser/android/

holte@chromium.org: Please review changes in tools/metrics/

[Bernhard Bauer, 2017-06-09 09:41:39]

lgtm

https://codereview.chromium.org/2927063002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
(right):

https://codereview.chromium.org/2927063002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java:35:
// TODO(dullweber): Remove this migration after after three milestones (probably
M63)
Should this be five milestones then? :) More srsly though, maybe just remove the
"three milestones" part, because it's not clear from when that is.

[dullweber, 2017-06-09 10:01:46]

dullweber@chromium.org changed reviewers:
+ holte@chromium.org

[dullweber, 2017-06-09 10:01:46]

holte@chromium.org: Please review changes in tools/metrics/

(I forgot to you to reviewers last time :D)

https://codereview.chromium.org/2927063002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
(right):

https://codereview.chromium.org/2927063002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java:35:
// TODO(dullweber): Remove this migration after after three milestones (probably
M63)
On 2017/06/09 09:41:39, Bernhard Bauer wrote:
> Should this be five milestones then? :) More srsly though, maybe just remove
the
> "three milestones" part, because it's not clear from when that is.

It took a bit longer than planned to get this ready, so I counted from 60
instead of 58 :D I removed the "three milestones" and added some explanation,
why this migration is need strictly needed if chrome is not used often.

[Steven Holte, 2017-06-09 19:46:57]

lgtm

[msramek, 2017-06-12 12:11:43]

LGTM

[dullweber, 2017-06-12 12:12:36]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-06-12 12:12:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2927063002/#ps40001
(title: "Update migration comment (and rebase)")

[commit-bot: I haz the power, 2017-06-12 12:12:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 13:51:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497269556470150,
"parent_rev": "0a8c2fcd5f0ca9236744f956610f8e0ad5d7f3c7", "commit_rev":
"412ef84048d767626e0d95ad2c14fd3f43398eff"}

[commit-bot: I haz the power, 2017-06-12 13:51:50]

Description was changed from

==========
Add metrics for new CBD dialog

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120
==========

to

==========
Add metrics for new CBD dialog

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120

Review-Url: https://codereview.chromium.org/2927063002
Cr-Commit-Position: refs/heads/master@{#478602}
Committed:
https://chromium.googlesource.com/chromium/src/+/412ef84048d767626e0d95ad2c14...
==========

[commit-bot: I haz the power, 2017-06-12 13:51:51]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/412ef84048d767626e0d95ad2c14...