components/browsing_data/core/clear_browsing_data_tab.h - Issue 2927063002: Add metrics for new CBD dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/browsing_data/core/clear_browsing_data_tab.h

Issue 2927063002: Add metrics for new CBD dialog (Closed)

Patch Set: Update migration comment (and rebase) Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/browsing_data/core/browsing_data_utils.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_	5 #ifndef COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_

6 #define COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_	6 #define COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_

7	7

8 namespace browsing_data {	8 namespace browsing_data {

9	9

10 // This enum is used to differentiate CBD preferences from the basic and	10 // This enum is used to differentiate CBD preferences from the basic and

11 // advanced tab and manage their state separately. It is important that all	11 // advanced tab and manage their state separately. It is important that all

12 // preferences and the timeperiod selection have the same type. The default	12 // preferences and the timeperiod selection have the same type. The default

13 // value for dialogs without separate tabs is advanced.	13 // value for dialogs without separate tabs is advanced.

14 // TODO(dullweber): Maybe rename "ADVANCED" to "DEFAULT" because it is used in	14 // TODO(dullweber): Maybe rename "ADVANCED" to "DEFAULT" because it is used in

15 // multiple places without a differentiation between advanced and basic.	15 // multiple places without a differentiation between advanced and basic.

16 //	16 //

	17 // Do not change the values here, as they are used for UMA histograms.

	18 //

17 // A Java counterpart will be generated for this enum.	19 // A Java counterpart will be generated for this enum.

18 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.browsing_data	20 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.browsing_data

19 enum class ClearBrowsingDataTab { BASIC, ADVANCED, NUM_TYPES };	21 enum class ClearBrowsingDataTab { BASIC, ADVANCED, NUM_TYPES };

20	22

21 } // namespace browsing_data	23 } // namespace browsing_data

22	24

23 #endif // COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_	25 #endif // COMPONENTS_BROWSING_DATA_CORE_CLEAR_BROWSING_DATA_TAB_H_

OLD	NEW