chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java - Issue 2927063002: Add metrics for new CBD dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

Issue 2927063002: Add metrics for new CBD dialog (Closed)

Patch Set: Update migration comment (and rebase) Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java ('k') | chrome/browser/android/browsing_data/browsing_data_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

index c45923a9ae68ea5fd4b15133a5f21aa3a12a4c52..59814cb10ce16da8ca45d7e5c830158f29f5bcde 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

@@ -17,6 +17,7 @@ import android.view.LayoutInflater;

import android.view.View;

import android.view.ViewGroup;

+import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

@@ -31,7 +32,9 @@ public class ClearBrowsingDataTabsFragment extends Fragment {

public static final int CBD_TAB_COUNT = 2;

public ClearBrowsingDataTabsFragment() {

- // TODO(dullweber): Remove this migration after after three milestones (probably M61)

+ // TODO(dullweber): Remove this migration after M62, most users should

+ // be migrated and the others will just get the default settings for

+ // the basic tab.

PrefServiceBridge.getInstance().migrateBrowsingDataPreferences();

}

@@ -45,6 +48,7 @@ public class ClearBrowsingDataTabsFragment extends Fragment {

@Override

public void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

+ RecordUserAction.record("ClearBrowsingData_DialogCreated");

}