chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java - Issue 2927063002: Add metrics for new CBD dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Issue 2927063002: Add metrics for new CBD dialog (Closed)

Patch Set: Update migration comment (and rebase) Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

index d3bae3652cb94962aa483d14388511f4627fb1fe..ddfd3beb24195ceaddc38ddfd350a6cbc8f32478 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

@@ -505,7 +505,11 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment

@Override

public void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

- RecordUserAction.record("ClearBrowsingData_DialogCreated");

+ // Don't record this action if TabsInCBD is enabled because this class is created twice.

+ // The action will be recorded in ClearBrowsingDataTabsFragment instead.

+ if (!ClearBrowsingDataTabsFragment.isFeatureEnabled()) {

+ RecordUserAction.record("ClearBrowsingData_DialogCreated");

+ }

mMaxImportantSites = BrowsingDataBridge.getMaxImportantSites();

BrowsingDataBridge.getInstance().requestInfoAboutOtherFormsOfBrowsingHistory(this);

getActivity().setTitle(R.string.clear_browsing_data_title);