Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: components/browsing_data/core/browsing_data_utils.cc

Issue 2927063002: Add metrics for new CBD dialog (Closed)
Patch Set: Update migration comment (and rebase) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browsing_data/core/browsing_data_utils.cc
diff --git a/components/browsing_data/core/browsing_data_utils.cc b/components/browsing_data/core/browsing_data_utils.cc
index ea7e7bb5cb44e14565e3103483a3ddd6399269d5..7dba88ed150cf7ccaeb3ceefd2acac7014db1d0e 100644
--- a/components/browsing_data/core/browsing_data_utils.cc
+++ b/components/browsing_data/core/browsing_data_utils.cc
@@ -4,6 +4,7 @@
#include "components/browsing_data/core/browsing_data_utils.h"
+#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "components/browsing_data/core/counters/autofill_counter.h"
#include "components/browsing_data/core/counters/history_counter.h"
@@ -65,6 +66,47 @@ void RecordDeletionForPeriod(TimePeriod period) {
}
}
+void RecordTimePeriodChange(TimePeriod period) {
+ switch (period) {
+ case TimePeriod::LAST_HOUR:
+ base::RecordAction(base::UserMetricsAction(
+ "ClearBrowsingData_TimePeriodChanged_LastHour"));
+ break;
+ case TimePeriod::LAST_DAY:
+ base::RecordAction(base::UserMetricsAction(
+ "ClearBrowsingData_TimePeriodChanged_LastDay"));
+ break;
+ case TimePeriod::LAST_WEEK:
+ base::RecordAction(base::UserMetricsAction(
+ "ClearBrowsingData_TimePeriodChanged_LastWeek"));
+ break;
+ case TimePeriod::FOUR_WEEKS:
+ base::RecordAction(base::UserMetricsAction(
+ "ClearBrowsingData_TimePeriodChanged_LastMonth"));
+ break;
+ case TimePeriod::ALL_TIME:
+ base::RecordAction(base::UserMetricsAction(
+ "ClearBrowsingData_TimePeriodChanged_Everything"));
+ break;
+ }
+}
+
+void RecordDeletionFromTab(ClearBrowsingDataTab tab) {
+ UMA_HISTOGRAM_ENUMERATION("History.ClearBrowsingData.UserDeletedFromTab", tab,
+ browsing_data::ClearBrowsingDataTab::NUM_TYPES);
+ switch (tab) {
+ case ClearBrowsingDataTab::BASIC:
+ base::RecordAction(base::UserMetricsAction("ClearBrowsingData_BasicTab"));
+ break;
+ case ClearBrowsingDataTab::ADVANCED:
+ base::RecordAction(
+ base::UserMetricsAction("ClearBrowsingData_AdvancedTab"));
+ break;
+ case ClearBrowsingDataTab::NUM_TYPES:
+ NOTREACHED();
+ }
+}
+
base::string16 GetCounterTextFromResult(
const BrowsingDataCounter::Result* result) {
base::string16 text;
« no previous file with comments | « components/browsing_data/core/browsing_data_utils.h ('k') | components/browsing_data/core/clear_browsing_data_tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698