Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2926053002:
Make RareNonInheritedData use MemberCopy and DataEquivalent. (Closed)
DescriptionMake RareNonInheritedData use MemberCopy and DataEquivalent.
When we generate RareNonInheritedData, the generated code will use
MemberCopy and DataEquivalent on all pointer fields. This patch first
changes the handwritten RareNonInheritedData to use these functions
in preparation for generating RareNonInheritedData.
Note that we have temporary overloads for DataRef. These will no longer
be needed once all subgroups of RareNonInheritedData are generated.
BUG=628043
Review-Url: https://codereview.chromium.org/2926053002
Cr-Commit-Position: refs/heads/master@{#478934}
Committed: https://chromium.googlesource.com/chromium/src/+/b8a5e4f08664ade94cc12c72cec6e208e03fad2d
Patch Set 1 #Patch Set 2 : Remove unintended change #Patch Set 3 : Rebase #Patch Set 4 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 38 (30 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shend@chromium.org to run a CQ dry run
shend@chromium.org changed reviewers: + nainar@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi Naina, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
shend@chromium.org changed reviewers: + alancutter@chromium.org - nainar@chromium.org
Hi Alan, PTAL
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nainar@chromium.org changed reviewers: + nainar@chromium.org
lgtm
I would ask that you get alancutter@'s opinion on MemberCopy but the other two lgtm
lgtm
The CQ bit was checked by shend@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2922163002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497341904355550,
"parent_rev": "3de8b2e022a8448fec77e19e47aa2d3dd769508f", "commit_rev":
"b8a5e4f08664ade94cc12c72cec6e208e03fad2d"}
Message was sent while issue was closed.
Description was changed from ========== Make RareNonInheritedData use MemberCopy and DataEquivalent. When we generate RareNonInheritedData, the generated code will use MemberCopy and DataEquivalent on all pointer fields. This patch first changes the handwritten RareNonInheritedData to use these functions in preparation for generating RareNonInheritedData. Note that we have temporary overloads for DataRef. These will no longer be needed once all subgroups of RareNonInheritedData are generated. BUG=628043 ========== to ========== Make RareNonInheritedData use MemberCopy and DataEquivalent. When we generate RareNonInheritedData, the generated code will use MemberCopy and DataEquivalent on all pointer fields. This patch first changes the handwritten RareNonInheritedData to use these functions in preparation for generating RareNonInheritedData. Note that we have temporary overloads for DataRef. These will no longer be needed once all subgroups of RareNonInheritedData are generated. BUG=628043 Review-Url: https://codereview.chromium.org/2926053002 Cr-Commit-Position: refs/heads/master@{#478934} Committed: https://chromium.googlesource.com/chromium/src/+/b8a5e4f08664ade94cc12c72cec6... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b8a5e4f08664ade94cc12c72cec6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
