Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

Issue 2926053002: Make RareNonInheritedData use MemberCopy and DataEquivalent. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/MemberCopy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 * 19 *
20 */ 20 */
21 21
22 #include "core/style/StyleRareNonInheritedData.h" 22 #include "core/style/StyleRareNonInheritedData.h"
23 23
24 #include "core/animation/css/CSSAnimationData.h" 24 #include "core/animation/css/CSSAnimationData.h"
25 #include "core/animation/css/CSSTransitionData.h" 25 #include "core/animation/css/CSSTransitionData.h"
26 #include "core/style/ComputedStyle.h"
26 #include "core/style/ContentData.h" 27 #include "core/style/ContentData.h"
27 #include "core/style/DataEquivalency.h" 28 #include "core/style/DataEquivalency.h"
28 #include "core/style/ComputedStyle.h" 29 #include "core/style/MemberCopy.h"
29 #include "core/style/ShadowList.h" 30 #include "core/style/ShadowList.h"
30 #include "core/style/StyleFilterData.h" 31 #include "core/style/StyleFilterData.h"
31 #include "core/style/StyleNonInheritedVariables.h" 32 #include "core/style/StyleNonInheritedVariables.h"
32 #include "core/style/StyleTransformData.h" 33 #include "core/style/StyleTransformData.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 class SameSizeStyleRareNonInheritedData 37 class SameSizeStyleRareNonInheritedData
37 : public RefCounted<StyleRareNonInheritedData> { 38 : public RefCounted<StyleRareNonInheritedData> {
38 public: 39 public:
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 const StyleRareNonInheritedData& o) 137 const StyleRareNonInheritedData& o)
137 : RefCounted<StyleRareNonInheritedData>(), 138 : RefCounted<StyleRareNonInheritedData>(),
138 opacity_(o.opacity_), 139 opacity_(o.opacity_),
139 perspective_(o.perspective_), 140 perspective_(o.perspective_),
140 shape_image_threshold_(o.shape_image_threshold_), 141 shape_image_threshold_(o.shape_image_threshold_),
141 order_(o.order_), 142 order_(o.order_),
142 perspective_origin_(o.perspective_origin_), 143 perspective_origin_(o.perspective_origin_),
143 object_position_(o.object_position_), 144 object_position_(o.object_position_),
144 line_clamp_(o.line_clamp_), 145 line_clamp_(o.line_clamp_),
145 draggable_region_mode_(o.draggable_region_mode_), 146 draggable_region_mode_(o.draggable_region_mode_),
146 deprecated_flexible_box_data_(o.deprecated_flexible_box_data_), 147 deprecated_flexible_box_data_(
147 flexible_box_data_(o.flexible_box_data_), 148 MemberCopy(o.deprecated_flexible_box_data_)),
148 multi_col_data_(o.multi_col_data_), 149 flexible_box_data_(MemberCopy(o.flexible_box_data_)),
149 transform_data_(o.transform_data_), 150 multi_col_data_(MemberCopy(o.multi_col_data_)),
150 will_change_data_(o.will_change_data_), 151 transform_data_(MemberCopy(o.transform_data_)),
151 filter_(o.filter_), 152 will_change_data_(MemberCopy(o.will_change_data_)),
152 backdrop_filter_(o.backdrop_filter_), 153 filter_(MemberCopy(o.filter_)),
153 grid_data_(o.grid_data_), 154 backdrop_filter_(MemberCopy(o.backdrop_filter_)),
154 grid_item_data_(o.grid_item_data_), 155 grid_data_(MemberCopy(o.grid_data_)),
155 scroll_snap_data_(o.scroll_snap_data_), 156 grid_item_data_(MemberCopy(o.grid_item_data_)),
156 content_(o.content_ ? o.content_->Clone() : nullptr), 157 scroll_snap_data_(MemberCopy(o.scroll_snap_data_)),
157 counter_directives_(o.counter_directives_ ? o.counter_directives_->Clone() 158 content_(MemberCopy(o.content_)),
158 : nullptr), 159 counter_directives_(MemberCopy(o.counter_directives_)),
159 animations_(o.animations_ ? o.animations_->Clone() : nullptr), 160 animations_(MemberCopy(o.animations_)),
160 transitions_(o.transitions_ ? o.transitions_->Clone() : nullptr), 161 transitions_(MemberCopy(o.transitions_)),
161 box_shadow_(o.box_shadow_), 162 box_shadow_(MemberCopy(o.box_shadow_)),
162 box_reflect_(o.box_reflect_), 163 box_reflect_(MemberCopy(o.box_reflect_)),
163 shape_outside_(o.shape_outside_), 164 shape_outside_(o.shape_outside_),
164 clip_path_(o.clip_path_), 165 clip_path_(MemberCopy(o.clip_path_)),
165 mask_(o.mask_), 166 mask_(o.mask_),
166 mask_box_image_(o.mask_box_image_), 167 mask_box_image_(o.mask_box_image_),
167 page_size_(o.page_size_), 168 page_size_(o.page_size_),
168 shape_margin_(o.shape_margin_), 169 shape_margin_(o.shape_margin_),
169 outline_(o.outline_), 170 outline_(o.outline_),
170 text_decoration_color_(o.text_decoration_color_), 171 text_decoration_color_(o.text_decoration_color_),
171 visited_link_text_decoration_color_( 172 visited_link_text_decoration_color_(
172 o.visited_link_text_decoration_color_), 173 o.visited_link_text_decoration_color_),
173 visited_link_background_color_(o.visited_link_background_color_), 174 visited_link_background_color_(o.visited_link_background_color_),
174 visited_link_outline_color_(o.visited_link_outline_color_), 175 visited_link_outline_color_(o.visited_link_outline_color_),
175 visited_link_border_left_color_(o.visited_link_border_left_color_), 176 visited_link_border_left_color_(o.visited_link_border_left_color_),
176 visited_link_border_right_color_(o.visited_link_border_right_color_), 177 visited_link_border_right_color_(o.visited_link_border_right_color_),
177 visited_link_border_top_color_(o.visited_link_border_top_color_), 178 visited_link_border_top_color_(o.visited_link_border_top_color_),
178 visited_link_border_bottom_color_(o.visited_link_border_bottom_color_), 179 visited_link_border_bottom_color_(o.visited_link_border_bottom_color_),
179 callback_selectors_(o.callback_selectors_), 180 callback_selectors_(o.callback_selectors_),
180 paint_images_(o.paint_images_ ? new PaintImages(*o.paint_images_) 181 paint_images_(MemberCopy(o.paint_images_)),
181 : nullptr), 182 non_inherited_variables_(MemberCopy(o.non_inherited_variables_)),
182 non_inherited_variables_(o.non_inherited_variables_
183 ? o.non_inherited_variables_->Clone()
184 : nullptr),
185 align_content_(o.align_content_), 183 align_content_(o.align_content_),
186 align_items_(o.align_items_), 184 align_items_(o.align_items_),
187 align_self_(o.align_self_), 185 align_self_(o.align_self_),
188 justify_content_(o.justify_content_), 186 justify_content_(o.justify_content_),
189 justify_items_(o.justify_items_), 187 justify_items_(o.justify_items_),
190 justify_self_(o.justify_self_), 188 justify_self_(o.justify_self_),
191 page_size_type_(o.page_size_type_), 189 page_size_type_(o.page_size_type_),
192 transform_style_3d_(o.transform_style_3d_), 190 transform_style_3d_(o.transform_style_3d_),
193 backface_visibility_(o.backface_visibility_), 191 backface_visibility_(o.backface_visibility_),
194 user_drag_(o.user_drag_), 192 user_drag_(o.user_drag_),
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 StyleRareNonInheritedData::~StyleRareNonInheritedData() {} 227 StyleRareNonInheritedData::~StyleRareNonInheritedData() {}
230 228
231 bool StyleRareNonInheritedData::operator==( 229 bool StyleRareNonInheritedData::operator==(
232 const StyleRareNonInheritedData& o) const { 230 const StyleRareNonInheritedData& o) const {
233 return opacity_ == o.opacity_ && perspective_ == o.perspective_ && 231 return opacity_ == o.opacity_ && perspective_ == o.perspective_ &&
234 shape_image_threshold_ == o.shape_image_threshold_ && 232 shape_image_threshold_ == o.shape_image_threshold_ &&
235 order_ == o.order_ && perspective_origin_ == o.perspective_origin_ && 233 order_ == o.order_ && perspective_origin_ == o.perspective_origin_ &&
236 object_position_ == o.object_position_ && 234 object_position_ == o.object_position_ &&
237 line_clamp_ == o.line_clamp_ && 235 line_clamp_ == o.line_clamp_ &&
238 draggable_region_mode_ == o.draggable_region_mode_ && 236 draggable_region_mode_ == o.draggable_region_mode_ &&
239 deprecated_flexible_box_data_ == o.deprecated_flexible_box_data_ && 237 DataEquivalent(deprecated_flexible_box_data_,
240 flexible_box_data_ == o.flexible_box_data_ && 238 o.deprecated_flexible_box_data_) &&
241 multi_col_data_ == o.multi_col_data_ && 239 DataEquivalent(flexible_box_data_, o.flexible_box_data_) &&
242 transform_data_ == o.transform_data_ && 240 DataEquivalent(multi_col_data_, o.multi_col_data_) &&
243 will_change_data_ == o.will_change_data_ && filter_ == o.filter_ && 241 DataEquivalent(transform_data_, o.transform_data_) &&
244 backdrop_filter_ == o.backdrop_filter_ && grid_data_ == o.grid_data_ && 242 DataEquivalent(will_change_data_, o.will_change_data_) &&
245 grid_item_data_ == o.grid_item_data_ && 243 DataEquivalent(filter_, o.filter_) &&
246 scroll_snap_data_ == o.scroll_snap_data_ && 244 DataEquivalent(backdrop_filter_, o.backdrop_filter_) &&
245 DataEquivalent(grid_data_, o.grid_data_) &&
246 DataEquivalent(grid_item_data_, o.grid_item_data_) &&
247 DataEquivalent(scroll_snap_data_, o.scroll_snap_data_) &&
247 DataEquivalent(content_, o.content_) && 248 DataEquivalent(content_, o.content_) &&
248 DataEquivalent(counter_directives_, o.counter_directives_) && 249 DataEquivalent(counter_directives_, o.counter_directives_) &&
249 DataEquivalent(box_shadow_, o.box_shadow_) && 250 DataEquivalent(box_shadow_, o.box_shadow_) &&
250 DataEquivalent(box_reflect_, o.box_reflect_) && 251 DataEquivalent(box_reflect_, o.box_reflect_) &&
251 DataEquivalent(animations_, o.animations_) && 252 DataEquivalent(animations_, o.animations_) &&
252 DataEquivalent(transitions_, o.transitions_) && 253 DataEquivalent(transitions_, o.transitions_) &&
253 DataEquivalent(shape_outside_, o.shape_outside_) && mask_ == o.mask_ && 254 DataEquivalent(shape_outside_, o.shape_outside_) && mask_ == o.mask_ &&
254 mask_box_image_ == o.mask_box_image_ && page_size_ == o.page_size_ && 255 mask_box_image_ == o.mask_box_image_ && page_size_ == o.page_size_ &&
255 shape_margin_ == o.shape_margin_ && outline_ == o.outline_ && 256 shape_margin_ == o.shape_margin_ && outline_ == o.outline_ &&
256 DataEquivalent(clip_path_, o.clip_path_) && 257 DataEquivalent(clip_path_, o.clip_path_) &&
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 requires_accelerated_compositing_for_external_reasons_ == 296 requires_accelerated_compositing_for_external_reasons_ ==
296 o.requires_accelerated_compositing_for_external_reasons_ && 297 o.requires_accelerated_compositing_for_external_reasons_ &&
297 has_inline_transform_ == o.has_inline_transform_ && 298 has_inline_transform_ == o.has_inline_transform_ &&
298 resize_ == o.resize_ && 299 resize_ == o.resize_ &&
299 has_compositor_proxy_ == o.has_compositor_proxy_ && 300 has_compositor_proxy_ == o.has_compositor_proxy_ &&
300 has_author_background_ == o.has_author_background_ && 301 has_author_background_ == o.has_author_background_ &&
301 has_author_border_ == o.has_author_border_; 302 has_author_border_ == o.has_author_border_;
302 } 303 }
303 304
304 } // namespace blink 305 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/MemberCopy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698