Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2923333002: Generate StyleRareNonInheritedData in ComputedStyleBase. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate StyleRareNonInheritedData in ComputedStyleBase. This patch generates the fields stored directly on StyleRareNonInheritedData. This group is special in that it has nested subgroups such as StyleWillChangeData and StyleTransformData. Important changes to note: - name_utilities.py: split_name is changed to consider "3D" as one word instead of two. This is so that the name for transform-style-3D is formatted correctly. - CSSProperties.json5: Added new pointer types std::unique_ptr and DataPersistent. Added DataRef temporarily as a valid pointer type so that the fields for nested groups like StyleWillChangeData can be generated, without generating the nested group itself. This is to keep the CL small. DataRef will be removed as a valid pointer type once all the subgroups are generated. - DataPersistent.h: Added move assignment so that the internal move setter for DataPersistent fields can be generated. - group.tmpl: Comparisons are not generated for a few fields. See https://www.diffchecker.com/u0H0SvNe for which fields are not compared. This change makes groups ignore these fields when generating operator==. This patch does not change behaviour. Diff of generated files: https://gist.github.com/781ba773a43594145ee79cfa270614d6/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2923333002 Cr-Commit-Position: refs/heads/master@{#479146} Committed: https://chromium.googlesource.com/chromium/src/+/3d43d6284ad6298b1487e5648cf43e46c44ba3a9

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Make smaller #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Total comments: 5

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -552 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 3 4 5 1 chunk +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/name_utilities.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 5 30 chunks +164 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 2 1 chunk +374 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 5 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/DataPersistent.h View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -228 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 2 1 chunk +0 lines, -305 lines 0 comments Download

Messages

Total messages: 41 (33 generated)
shend
Hi Naina, PTAL. Lemme know if I should split this patch up further.
3 years, 6 months ago (2017-06-07 01:30:44 UTC) #8
shend
Bots aren't passing because parent patch modifies a file that this patch deletes.
3 years, 6 months ago (2017-06-07 22:59:25 UTC) #22
nainar
lgtm for all excluding core/style/DataPersistent.h. Not an expert here. https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode27 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:27: ...
3 years, 6 months ago (2017-06-12 23:20:55 UTC) #23
shend
Hi Alan, PTAL for core/style/DataPersistent.h
3 years, 6 months ago (2017-06-13 01:04:00 UTC) #25
alancutter (OOO until 2018)
Very impressive! lgtm. https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/core/css/CSSProperties.json5 File third_party/WebKit/Source/core/css/CSSProperties.json5 (right): https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/core/css/CSSProperties.json5#newcode611 third_party/WebKit/Source/core/css/CSSProperties.json5:611: default_value: "StyleSelfAlignmentData(RuntimeEnabledFeatures::CSSGridLayoutEnabled() ? kItemPositionNormal : kItemPositionStretch, ...
3 years, 6 months ago (2017-06-13 03:49:29 UTC) #26
shend
https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/core/css/CSSProperties.json5 File third_party/WebKit/Source/core/css/CSSProperties.json5 (right): https://codereview.chromium.org/2923333002/diff/80001/third_party/WebKit/Source/core/css/CSSProperties.json5#newcode611 third_party/WebKit/Source/core/css/CSSProperties.json5:611: default_value: "StyleSelfAlignmentData(RuntimeEnabledFeatures::CSSGridLayoutEnabled() ? kItemPositionNormal : kItemPositionStretch, kOverflowAlignmentDefault)", On 2017/06/13 ...
3 years, 6 months ago (2017-06-13 20:54:43 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923333002/100001
3 years, 6 months ago (2017-06-13 20:55:34 UTC) #38
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 21:00:59 UTC) #41
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/3d43d6284ad6298b1487e5648cf4...

Powered by Google App Engine
This is Rietveld 408576698