Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2922163002:
Remove explicit template parameters when calling DataEquivalent. (Closed)
DescriptionRemove explicit template parameters when calling DataEquivalent.
Because of crbug.com/729447, specifying explicit template parameters
in a call to a function that is overloaded on a garbage collected type
causes a [blink-gc] error. As part of generating RareNonInheritedData,
we need to add overloads for DataRef in DataEquivalent, so we need to
remove code where DataEquivalent is called with explicit template
parameters.
This patch replaces explicit template parameters with static_casts
instead. This workaround will allow us to continue with generating
RareNonInheritedData.
BUG=628043
Review-Url: https://codereview.chromium.org/2922163002
Cr-Commit-Position: refs/heads/master@{#478908}
Committed: https://chromium.googlesource.com/chromium/src/+/26be5c373bf2361010a3c06929d342a530043634
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #
Dependent Patchsets: Messages
Total messages: 32 (25 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== remove BUG= ========== to ========== Remove explicit template parameters when calling DataEquivalent. Because of crbug.com/729447, specifying explicit template parameters in a call to a function that is overloaded on a garbage collected type causes a [blink-gc] error. As part of generating RareNonInheritedData, we need to add overloads for DataRef in DataEquivalent, so we need to remove code where DataEquivalent is called with explicit template parameters. This patch replaces explicit template parameters with static_casts instead. This workaround will allow us to continue with generating RareNonInheritedData. BUG=628043 ==========
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
shend@chromium.org changed reviewers: + alancutter@chromium.org - nainar@chromium.org
Redirecting to Alan, PTAL
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nainar@chromium.org changed reviewers: + nainar@chromium.org
lgtm
shend@, Argh sorry meant to hit Publish. Not l*tm. I am not that familiar with DataEquivalent and I think alancutter@ is better suited here.
lgtm
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497324997710990,
"parent_rev": "1aafc6b9d8fd263a4bac55fbc8c7842b65de585c", "commit_rev":
"26be5c373bf2361010a3c06929d342a530043634"}
Message was sent while issue was closed.
Description was changed from ========== Remove explicit template parameters when calling DataEquivalent. Because of crbug.com/729447, specifying explicit template parameters in a call to a function that is overloaded on a garbage collected type causes a [blink-gc] error. As part of generating RareNonInheritedData, we need to add overloads for DataRef in DataEquivalent, so we need to remove code where DataEquivalent is called with explicit template parameters. This patch replaces explicit template parameters with static_casts instead. This workaround will allow us to continue with generating RareNonInheritedData. BUG=628043 ========== to ========== Remove explicit template parameters when calling DataEquivalent. Because of crbug.com/729447, specifying explicit template parameters in a call to a function that is overloaded on a garbage collected type causes a [blink-gc] error. As part of generating RareNonInheritedData, we need to add overloads for DataRef in DataEquivalent, so we need to remove code where DataEquivalent is called with explicit template parameters. This patch replaces explicit template parameters with static_casts instead. This workaround will allow us to continue with generating RareNonInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2922163002 Cr-Commit-Position: refs/heads/master@{#478908} Committed: https://chromium.googlesource.com/chromium/src/+/26be5c373bf2361010a3c06929d3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/26be5c373bf2361010a3c06929d3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
