Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/core/style/DataEquivalency.h

Issue 2926053002: Make RareNonInheritedData use MemberCopy and DataEquivalent. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/MemberCopy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DataEquivalency_h 5 #ifndef DataEquivalency_h
6 #define DataEquivalency_h 6 #define DataEquivalency_h
7 7
8 #include <memory> 8 #include <memory>
9 #include "platform/wtf/RefPtr.h" 9 #include "platform/wtf/RefPtr.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 template <typename T> 13 template <typename T>
14 class Persistent; 14 class Persistent;
15 template <typename T> 15 template <typename T>
16 class Member; 16 class Member;
17 template <typename T>
18 class DataRef;
19 template <typename T>
20 class DataPersistent;
17 21
18 template <typename T> 22 template <typename T>
19 bool DataEquivalent(const T* a, const T* b) { 23 bool DataEquivalent(const T* a, const T* b) {
20 if (a == b) 24 if (a == b)
21 return true; 25 return true;
22 if (!a || !b) 26 if (!a || !b)
23 return false; 27 return false;
24 return *a == *b; 28 return *a == *b;
25 } 29 }
26 30
(...skipping 10 matching lines...) Expand all
37 template <typename T> 41 template <typename T>
38 bool DataEquivalent(const Member<T>& a, const Member<T>& b) { 42 bool DataEquivalent(const Member<T>& a, const Member<T>& b) {
39 return DataEquivalent(a.Get(), b.Get()); 43 return DataEquivalent(a.Get(), b.Get());
40 } 44 }
41 45
42 template <typename T> 46 template <typename T>
43 bool DataEquivalent(const std::unique_ptr<T>& a, const std::unique_ptr<T>& b) { 47 bool DataEquivalent(const std::unique_ptr<T>& a, const std::unique_ptr<T>& b) {
44 return DataEquivalent(a.get(), b.get()); 48 return DataEquivalent(a.get(), b.get());
45 } 49 }
46 50
51 // TODO(shend): Remove this once all subgroups of StyleRareNonInheritedData are
52 // generated
53 template <typename T>
54 bool DataEquivalent(const DataRef<T>& a, const DataRef<T>& b) {
55 return DataEquivalent(a.Get(), b.Get());
56 }
57
58 template <typename T>
59 bool DataEquivalent(const DataPersistent<T>& a, const DataPersistent<T>& b) {
60 return DataEquivalent(a.Get(), b.Get());
61 }
62
47 } // namespace blink 63 } // namespace blink
48 64
49 #endif // DataEquivalency_h 65 #endif // DataEquivalency_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/MemberCopy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698