Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2922933002: Remove |accept_states_| from PermissionRequestManager (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |accept_states_| from PermissionRequestManager PermissionRequestManager previously stored accept_states_ for tracking the state of the Allow/Block drop-down for each permission in a grouped permission request. These drop-downs are being removed, so this removes accept_states. There can still be grouped permission prompts though (for mic/camera) so this changes the behavior of Accept() to accept all permissions in the request, and Deny() to deny all permissions in the request. The UMA recording functions have been updated accordingly. BUG=728483 Review-Url: https://codereview.chromium.org/2922933002 Cr-Commit-Position: refs/heads/master@{#477439} Committed: https://chromium.googlesource.com/chromium/src/+/85102c98e4932dba40d36b19c95cff077c86e0ba

Patch Set 1 #

Patch Set 2 : Remove |accept_states_| from PermissionRequestManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -123 lines) Patch
M chrome/browser/permissions/permission_request_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 7 chunks +11 lines, -31 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager_unittest.cc View 1 10 chunks +3 lines, -46 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 2 chunks +37 lines, -38 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
raymes
3 years, 6 months ago (2017-06-06 03:16:43 UTC) #5
Timothy Loh
On 2017/06/06 03:16:43, raymes wrote: lgtm
3 years, 6 months ago (2017-06-06 03:25:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922933002/20001
3 years, 6 months ago (2017-06-06 22:22:46 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 22:28:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85102c98e4932dba40d36b19c95c...

Powered by Google App Engine
This is Rietveld 408576698