Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2922313002: Remove remaining dead code that was used to implement grouped permission drop downs (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
tapted, Timothy Loh
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, tfarina, lgarron+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining dead code that was used to implement grouped permission drop downs Grouped permission requests are being removed, except in the case of Mic/Camera. In that case, there will not be Allow/Block drop-downs for each permission requested. Instead there will be 2 individual Allow/Block buttons as in the case of single permission requests. This CL removes the remaining dead code that was used to implement the drop-downs. BUG=728483 Review-Url: https://codereview.chromium.org/2922313002 Cr-Commit-Position: refs/heads/master@{#477536} Committed: https://chromium.googlesource.com/chromium/src/+/27eec01fb796388d60e049444c65ebe2be738428

Patch Set 1 #

Patch Set 2 : Remove remaining dead code that was used to implement grouped permission drop downs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -89 lines) Patch
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_prompt_android.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm View 1 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/page_info/permission_menu_model.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/page_info/permission_menu_model.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/page_info/permission_menu_model_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/permission_bubble/permission_prompt.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
raymes
timloh: ptal tapted: ptal at the simple changes in chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
3 years, 6 months ago (2017-06-06 22:49:13 UTC) #5
Timothy Loh
lgtm Typo in patch description? "the i drop-downs."
3 years, 6 months ago (2017-06-07 02:58:07 UTC) #8
tapted
lgtm
3 years, 6 months ago (2017-06-07 03:28:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922313002/20001
3 years, 6 months ago (2017-06-07 03:30:19 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 03:35:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27eec01fb796388d60e049444c65...

Powered by Google App Engine
This is Rietveld 408576698