Remove remaining dead code that was used to implement grouped permission drop downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the
drop-downs.
BUG=728483
Review-Url: https://codereview.chromium.org/2922313002
Cr-Commit-Position: refs/heads/master@{#477536}
Committed: https://chromium.googlesource.com/chromium/src/+/27eec01fb796388d60e049444c65ebe2be738428
Description was changed from ========== Remove remaining dead code that was used to implement grouped ...
3 years, 6 months ago
(2017-06-06 22:45:48 UTC)
#1
Description was changed from
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
BUG=
==========
to
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the i
drop-downs.
BUG=728483
==========
raymes
The CQ bit was checked by raymes@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-06 22:47:06 UTC)
#2
3 years, 6 months ago
(2017-06-07 00:02:24 UTC)
#7
Dry run: This issue passed the CQ dry run.
Timothy Loh
lgtm Typo in patch description? "the i drop-downs."
3 years, 6 months ago
(2017-06-07 02:58:07 UTC)
#8
lgtm
Typo in patch description? "the i drop-downs."
raymes
Description was changed from ========== Remove remaining dead code that was used to implement grouped ...
3 years, 6 months ago
(2017-06-07 02:58:38 UTC)
#9
Description was changed from
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the i
drop-downs.
BUG=728483
==========
to
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the
drop-downs.
BUG=728483
==========
raymes
The CQ bit was checked by raymes@chromium.org
3 years, 6 months ago
(2017-06-07 02:58:45 UTC)
#10
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496806202159240, "parent_rev": "44098da69108f7a5525edbfb307cf73c9902de66", "commit_rev": "27eec01fb796388d60e049444c65ebe2be738428"}
3 years, 6 months ago
(2017-06-07 03:35:28 UTC)
#15
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496806202159240,
"parent_rev": "44098da69108f7a5525edbfb307cf73c9902de66", "commit_rev":
"27eec01fb796388d60e049444c65ebe2be738428"}
commit-bot: I haz the power
Description was changed from ========== Remove remaining dead code that was used to implement grouped ...
3 years, 6 months ago
(2017-06-07 03:35:39 UTC)
#16
Message was sent while issue was closed.
Description was changed from
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the
drop-downs.
BUG=728483
==========
to
==========
Remove remaining dead code that was used to implement grouped permission drop
downs
Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.
This CL removes the remaining dead code that was used to implement the
drop-downs.
BUG=728483
Review-Url: https://codereview.chromium.org/2922313002
Cr-Commit-Position: refs/heads/master@{#477536}
Committed:
https://chromium.googlesource.com/chromium/src/+/27eec01fb796388d60e049444c65...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/27eec01fb796388d60e049444c65ebe2be738428
3 years, 6 months ago
(2017-06-07 03:35:41 UTC)
#17
Issue 2922313002: Remove remaining dead code that was used to implement grouped permission drop downs
(Closed)
Created 3 years, 6 months ago by raymes
Modified 3 years, 6 months ago
Reviewers: Timothy Loh, tapted
Base URL:
Comments: 0