Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2161)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2922933002: Remove |accept_states_| from PermissionRequestManager (Closed)
Patch Set: Remove |accept_states_| from PermissionRequestManager Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 9ddfcf5a3393199dfb44a1293ce75b8b9a1eee25..45305b15c1a75ddd61e955a735d4e95ff0861ab9 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -390,48 +390,13 @@ void PermissionUmaUtil::PermissionPromptShown(
}
void PermissionUmaUtil::PermissionPromptAccepted(
- const std::vector<PermissionRequest*>& requests,
- const std::vector<bool>& accept_states) {
- DCHECK(!requests.empty());
- DCHECK(requests.size() == accept_states.size());
-
- bool all_accepted = accept_states[0];
- PermissionRequestType permission_prompt_type =
- requests[0]->GetPermissionRequestType();
- PermissionRequestGestureType permission_gesture_type =
- requests[0]->GetGestureType();
- if (requests.size() > 1) {
- permission_prompt_type = PermissionRequestType::MULTIPLE;
- permission_gesture_type = PermissionRequestGestureType::UNKNOWN;
- for (size_t i = 0; i < requests.size(); ++i) {
- const auto* request = requests[i];
- if (accept_states[i]) {
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleAccepted,
- request->GetPermissionRequestType());
- } else {
- all_accepted = false;
- PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleDenied,
- request->GetPermissionRequestType());
- }
- }
- }
-
- if (all_accepted) {
- RecordPermissionPromptAccepted(permission_prompt_type,
- permission_gesture_type);
- } else {
- RecordPermissionPromptDenied(permission_prompt_type,
- permission_gesture_type);
- }
+ const std::vector<PermissionRequest*>& requests) {
+ RecordPromptDecided(requests, /*accepted=*/true);
}
void PermissionUmaUtil::PermissionPromptDenied(
const std::vector<PermissionRequest*>& requests) {
- DCHECK(!requests.empty());
- DCHECK(requests.size() == 1);
-
- RecordPermissionPromptDenied(requests[0]->GetPermissionRequestType(),
- requests[0]->GetGestureType());
+ RecordPromptDecided(requests, /*accepted=*/false);
}
void PermissionUmaUtil::RecordPermissionPromptShown(
@@ -714,3 +679,37 @@ void PermissionUmaUtil::RecordPermissionAction(
rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
}
}
+
+// static
+void PermissionUmaUtil::RecordPromptDecided(
+ const std::vector<PermissionRequest*>& requests,
+ bool accepted) {
+ DCHECK(!requests.empty());
+
+ PermissionRequestType permission_prompt_type =
+ requests[0]->GetPermissionRequestType();
+ PermissionRequestGestureType permission_gesture_type =
+ requests[0]->GetGestureType();
+ if (requests.size() > 1) {
+ permission_prompt_type = PermissionRequestType::MULTIPLE;
+ permission_gesture_type = PermissionRequestGestureType::UNKNOWN;
+ for (size_t i = 0; i < requests.size(); ++i) {
+ const auto* request = requests[i];
+ if (accepted) {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleAccepted,
+ request->GetPermissionRequestType());
+ } else {
+ PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptMergedBubbleDenied,
+ request->GetPermissionRequestType());
+ }
+ }
+ }
+
+ if (accepted) {
+ RecordPermissionPromptAccepted(permission_prompt_type,
+ permission_gesture_type);
+ } else {
+ RecordPermissionPromptDenied(permission_prompt_type,
+ permission_gesture_type);
+ }
+}
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698