Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 2917353003: Remove the permission toggles from grouped permission infobars on Android (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
Timothy Loh, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the permission toggles from grouped permission infobars on Android Only mic/camera permissions will be allowed to be grouped going forward and these will not have a toggle allowing selecting each individual permission. This removes those toggles from the Android grouped infobars. BUG=728483 Review-Url: https://codereview.chromium.org/2917353003 Cr-Commit-Position: refs/heads/master@{#477434} Committed: https://chromium.googlesource.com/chromium/src/+/553c6205012763878d78ad8ca19e468efe9ec244

Patch Set 1 #

Patch Set 2 : Remove the permission allow toggles from grouped permission infobars on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -93 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java View 1 3 chunks +4 lines, -59 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.cc View 1 2 chunks +0 lines, -23 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
raymes
3 years, 6 months ago (2017-06-05 05:30:16 UTC) #2
Timothy Loh
On 2017/06/05 05:30:16, raymes wrote: lgtm
3 years, 6 months ago (2017-06-05 05:40:43 UTC) #5
raymes
dfalcantara: ptal
3 years, 6 months ago (2017-06-06 03:03:43 UTC) #9
gone
lgtm
3 years, 6 months ago (2017-06-06 17:13:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917353003/20001
3 years, 6 months ago (2017-06-06 22:15:55 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 22:21:07 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/553c6205012763878d78ad8ca19e...

Powered by Google App Engine
This is Rietveld 408576698