Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2922933002: Remove |accept_states_| from PermissionRequestManager (Closed)
Patch Set: Remove |accept_states_| from PermissionRequestManager Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index 2fa063cbc5d3bfd786151b45fb946f1f43102617..c32c7b257f497c3956d23a6e316aea1604b74f3a 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -160,12 +160,8 @@ class PermissionUmaUtil {
// The following two functions can be combined with the PermissionPromptShown
// metrics to calculate accept, deny and ignore rates.
- // Note that for coalesced permission bubbles, PermissionPromptAccepted will
- // always be called, with |accept_states| containing whether each request was
- // accepted or denied.
static void PermissionPromptAccepted(
- const std::vector<PermissionRequest*>& requests,
- const std::vector<bool>& accept_states);
+ const std::vector<PermissionRequest*>& requests);
static void PermissionPromptDenied(
const std::vector<PermissionRequest*>& requests);
@@ -219,6 +215,10 @@ class PermissionUmaUtil {
const std::string& prefix,
int count);
+ static void RecordPromptDecided(
+ const std::vector<PermissionRequest*>& requests,
+ bool accepted);
+
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
};
« no previous file with comments | « chrome/browser/permissions/permission_request_manager_unittest.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698