Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053, 729054
TBR=lazyboy@chromium.org

Review-Url: https://codereview.chromium.org/2922663002
Cr-Commit-Position: refs/heads/master@{#477164}
Committed: https://chromium.googlesource.com/chromium/src/+/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251

[tbansal1, 2017-06-02 07:17:10]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 07:17:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 07:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 07:27:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tbansal1, 2017-06-02 07:54:19]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 07:54:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 08:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 08:16:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tbansal1, 2017-06-02 16:23:34]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-06-02 16:25:37]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-06-02 16:26:18]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2017-06-02 16:33:23]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 16:33:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-02 16:42:49]

Description was changed from

==========
drp flag rm

BUG=
==========

to

==========
Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053,729054
==========

[tbansal1, 2017-06-02 16:44:35]

tbansal@chromium.org changed reviewers:
+ megjablon@chromium.org

[tbansal1, 2017-06-02 16:44:36]

megjablon: ptal. Thanks.

[commit-bot: I haz the power, 2017-06-02 17:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:11:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tbansal1, 2017-06-02 17:21:57]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:22:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-02 17:35:29]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-06-02 17:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:54:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tbansal1, 2017-06-02 17:57:37]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:57:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 20:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 20:53:57]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-06-02 21:25:02]

Patchset #1 (id:80001) has been deleted

[megjablon, 2017-06-02 23:01:50]

Thanks so much for doing this! This is awesome cleanup.

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:81:
void DataReductionProxySettings::UpdateConfigValues() {
Remove this method.

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
(right):

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h:175:
bool PromoAllowed() const {
It doesn't look like this called from anywhere other than
data_reduction_proxy_settings_android.cc. Can we remove this method and just
call drp::params::IsIncludedInPromoFieldTrial() there?

[tbansal1, 2017-06-04 01:57:51]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 01:58:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 02:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 02:06:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tbansal1, 2017-06-04 11:46:05]

Patchset #2 (id:120001) has been deleted

[tbansal1, 2017-06-04 11:46:09]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 11:46:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 12:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 12:47:37]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-06-05 13:48:24]

megjablon: ptal. Thanks.

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:81:
void DataReductionProxySettings::UpdateConfigValues() {
On 2017/06/02 23:01:50, megjablon wrote:
> Remove this method.

More cleanup. Yay!
Done.

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
(right):

https://codereview.chromium.org/2922663002/diff/100001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h:175:
bool PromoAllowed() const {
On 2017/06/02 23:01:50, megjablon wrote:
> It doesn't look like this called from anywhere other than
> data_reduction_proxy_settings_android.cc. Can we remove this method and just
> call drp::params::IsIncludedInPromoFieldTrial() there?

Done.

[megjablon, 2017-06-05 20:58:05]

lgtm

[tbansal1, 2017-06-05 21:15:31]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:16:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 21:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:28:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tbansal1, 2017-06-05 21:30:14]

Description was changed from

==========
Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053,729054
==========

to

==========
Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053,729054
TBR=lazyboy@chromium.org
==========

[tbansal1, 2017-06-05 21:31:00]

TBR'ing lazyboy@chromium.org for 
chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc since
this is a simple mechanical change.

[tbansal1, 2017-06-05 21:31:30]

tbansal@chromium.org changed reviewers:
+ lazyboy@chromium.org

[tbansal1, 2017-06-05 21:31:36]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:32:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-05 23:29:13]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2017-06-05 23:29:21]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:29:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-05 23:30:20]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2017-06-05 23:30:36]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:31:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 03:01:59]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1496705436449830,
"parent_rev": "a0889dfe98719a8e00d2d55fb1f4dbeced939707", "commit_rev":
"fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251"}

[commit-bot: I haz the power, 2017-06-06 03:02:16]

Description was changed from

==========
Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053,729054
TBR=lazyboy@chromium.org
==========

to

==========
Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if 
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also 
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG=729053,729054
TBR=lazyboy@chromium.org

Review-Url: https://codereview.chromium.org/2922663002
Cr-Commit-Position: refs/heads/master@{#477164}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbf8bb28d6cf83c4055ad5d85010...
==========

[commit-bot: I haz the power, 2017-06-06 03:02:17]

Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/fbf8bb28d6cf83c4055ad5d85010...