Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc

Issue 2922663002: Data Reduction Proxy: Remove duplicate functions (Closed)
Patch Set: megjablon comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
index acb1d4685389de11a067d99e5cfe2a0e6cc2a26c..421cca58811cabe85e0402f4cb262beb7659f1ac 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
@@ -16,16 +16,12 @@ DataReductionProxyMutableConfigValues::CreateFromParams(
const DataReductionProxyParams* params) {
std::unique_ptr<DataReductionProxyMutableConfigValues> config_values(
new DataReductionProxyMutableConfigValues());
- config_values->promo_allowed_ = params->promo_allowed();
- config_values->holdback_ = params->holdback();
config_values->secure_proxy_check_url_ = params->secure_proxy_check_url();
return config_values;
}
DataReductionProxyMutableConfigValues::DataReductionProxyMutableConfigValues()
- : promo_allowed_(false),
- holdback_(false),
- use_override_proxies_for_http_(false) {
+ : use_override_proxies_for_http_(false) {
use_override_proxies_for_http_ =
params::GetOverrideProxiesForHttpFromCommandLine(
&override_proxies_for_http_);
@@ -38,14 +34,6 @@ DataReductionProxyMutableConfigValues::
~DataReductionProxyMutableConfigValues() {
}
-bool DataReductionProxyMutableConfigValues::promo_allowed() const {
- return promo_allowed_;
-}
-
-bool DataReductionProxyMutableConfigValues::holdback() const {
- return holdback_;
-}
-
const std::vector<DataReductionProxyServer>&
DataReductionProxyMutableConfigValues::proxies_for_http() const {
DCHECK(thread_checker_.CalledOnValidThread());

Powered by Google App Engine
This is Rietveld 408576698