Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

Issue 2922663002: Data Reduction Proxy: Remove duplicate functions (Closed)
Patch Set: megjablon comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
index f5a610b1dfdd3a972951bef62d850a3780c02edd..df652759579dd023d0cd583a034e29bc6e40084f 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
@@ -294,9 +294,7 @@ DataStore::Status TestDataStore::RecreateDB() {
}
DataReductionProxyTestContext::Builder::Builder()
- : params_flags_(DataReductionProxyParams::kPromoAllowed),
- params_definitions_(TestDataReductionProxyParams::HAS_EVERYTHING),
- client_(Client::UNKNOWN),
+ : client_(Client::UNKNOWN),
request_context_(nullptr),
mock_socket_factory_(nullptr),
use_mock_config_(false),
@@ -308,19 +306,6 @@ DataReductionProxyTestContext::Builder::Builder()
DataReductionProxyTestContext::Builder::~Builder() {}
-DataReductionProxyTestContext::Builder&
-DataReductionProxyTestContext::Builder::WithParamsFlags(int params_flags) {
- params_flags_ = params_flags;
- return *this;
-}
-
-DataReductionProxyTestContext::Builder&
-DataReductionProxyTestContext::Builder::WithParamsDefinitions(
- unsigned int params_definitions) {
- params_definitions_ = params_definitions;
- return *this;
-}
-
DataReductionProxyTestContext::Builder&
DataReductionProxyTestContext::Builder::WithURLRequestContext(
net::URLRequestContext* request_context) {
@@ -424,7 +409,7 @@ DataReductionProxyTestContext::Builder::Build() {
std::unique_ptr<DataReductionProxyConfigServiceClient> config_client;
DataReductionProxyMutableConfigValues* raw_mutable_config = nullptr;
std::unique_ptr<TestDataReductionProxyParams> params(
- new TestDataReductionProxyParams(params_flags_, params_definitions_));
+ new TestDataReductionProxyParams());
TestDataReductionProxyParams* raw_params = params.get();
if (use_config_client_) {
test_context_flags |= USE_CONFIG_CLIENT;

Powered by Google App Engine
This is Rietveld 408576698