Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

Issue 2922663002: Data Reduction Proxy: Remove duplicate functions (Closed)
Patch Set: megjablon comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
index fb75ff2e24e2fb0ffffe06e38114ae29e6452c31..4cb09667a6bc2fad63550eec80be9fbbc412a286 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
@@ -103,7 +103,7 @@ class DataReductionProxyIODataTest : public testing::Test {
TEST_F(DataReductionProxyIODataTest, TestConstruction) {
std::unique_ptr<DataReductionProxyIOData> io_data(
- new DataReductionProxyIOData(Client::UNKNOWN, 0, net_log(), task_runner(),
+ new DataReductionProxyIOData(Client::UNKNOWN, net_log(), task_runner(),
task_runner(), false /* enabled */,
std::string() /* user_agent */,
std::string() /* channel */));
@@ -153,7 +153,6 @@ TEST_F(DataReductionProxyIODataTest, TestResetBadProxyListOnDisableDataSaver) {
net::TestURLRequestContext context(false);
std::unique_ptr<DataReductionProxyTestContext> drp_test_context =
DataReductionProxyTestContext::Builder()
- .WithParamsFlags(DataReductionProxyParams::kPromoAllowed)
.WithURLRequestContext(&context)
.SkipSettingsInitialization()
.Build();
@@ -191,10 +190,11 @@ TEST_F(DataReductionProxyIODataTest, TestResetBadProxyListOnDisableDataSaver) {
TEST_F(DataReductionProxyIODataTest, HoldbackConfiguresProxies) {
net::TestURLRequestContext context(false);
+ base::FieldTrialList field_trial_list(nullptr);
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+ "DataCompressionProxyHoldback", "Enabled"));
std::unique_ptr<DataReductionProxyTestContext> drp_test_context =
DataReductionProxyTestContext::Builder()
- .WithParamsFlags(DataReductionProxyParams::kPromoAllowed |
- DataReductionProxyParams::kHoldback)
.WithURLRequestContext(&context)
.SkipSettingsInitialization()
.Build();

Powered by Google App Engine
This is Rietveld 408576698