Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

Issue 2922663002: Data Reduction Proxy: Remove duplicate functions (Closed)
Patch Set: megjablon comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
index 6846173a474913ed9b10a3e2e2de14c8130ad792..eb864a6659fa1c255d5f2f6a6ff4c3cb3769ccd5 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
@@ -50,12 +50,8 @@ class DataReductionProxySettingsTestBase : public testing::Test {
void SetUp() override;
template <class C>
- void ResetSettings(std::unique_ptr<base::Clock> clock,
- bool promo_allowed,
- bool holdback);
- virtual void ResetSettings(std::unique_ptr<base::Clock> clock,
- bool promo_allowed,
- bool holdback) = 0;
+ void ResetSettings(std::unique_ptr<base::Clock> clock);
+ virtual void ResetSettings(std::unique_ptr<base::Clock> clock) = 0;
void ExpectSetProxyPrefs(bool expected_enabled,
bool expected_at_startup);
@@ -88,11 +84,9 @@ class ConcreteDataReductionProxySettingsTest
: public DataReductionProxySettingsTestBase {
public:
typedef MockDataReductionProxySettings<C> MockSettings;
- void ResetSettings(std::unique_ptr<base::Clock> clock,
- bool promo_allowed,
- bool holdback) override {
+ void ResetSettings(std::unique_ptr<base::Clock> clock) override {
return DataReductionProxySettingsTestBase::ResetSettings<C>(
- std::move(clock), promo_allowed, holdback);
+ std::move(clock));
}
};

Powered by Google App Engine
This is Rietveld 408576698