Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2919203002: [WASM] Eliminate SIMD boolean vector types. (Closed)

Created:
3 years, 6 months ago by bbudge
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Eliminate SIMD boolean vector types. - Eliminates b1x4, b1x8, and b1x16 as distinct WASM types. - All vector comparisons return v128 type. - Eliminates b1xN and, or, xor, not. - Selects take a v128 mask vector and are now bit-wise. - Adds a new test for Select, where mask is non-canonical (not 0's and -1's). LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2919203002 Cr-Commit-Position: refs/heads/master@{#45795} Committed: https://chromium.googlesource.com/v8/v8/+/381f7da02c4d8a641f329d23e06f99d7c75d5643

Patch Set 1 #

Patch Set 2 : Add tests for non-canonical selects. #

Patch Set 3 : Fix MIPS. #

Patch Set 4 : Fix comments in tests. #

Patch Set 5 : Eliminate Simd1xN machine types. Select is now bit-wise. #

Patch Set 6 : Rebase. #

Patch Set 7 : Fix builds. #

Patch Set 8 : Restore DCHECKs in AssembleMove/Swap now that we're back to 1 SIMD representation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -886 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 10 chunks +15 lines, -57 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 4 4 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 4 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 4 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 2 chunks +3 lines, -15 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 10 chunks +25 lines, -102 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 2 3 4 3 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/machine-graph-verifier.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 3 4 1 chunk +1 line, -20 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 3 4 5 chunks +1 line, -30 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 3 4 5 6 3 chunks +1 line, -3 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 5 6 9 chunks +9 lines, -48 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 3 4 5 6 3 chunks +1 line, -3 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 5 6 10 chunks +9 lines, -51 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 4 5 1 chunk +1 line, -18 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 2 3 4 4 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 2 3 4 4 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/simd-scalar-lowering.h View 1 2 3 4 1 chunk +1 line, -9 lines 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 1 2 3 4 7 chunks +12 lines, -19 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 4 5 2 chunks +2 lines, -56 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 8 chunks +11 lines, -35 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 2 3 4 4 chunks +0 lines, -12 lines 0 comments Download
M src/machine-type.h View 1 2 3 4 4 chunks +1 line, -30 lines 0 comments Download
M src/machine-type.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/wasm/function-body-decoder-impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 2 3 4 13 chunks +52 lines, -113 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 2 3 4 1 chunk +1 line, -15 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 4 chunks +42 lines, -104 lines 0 comments Download

Messages

Total messages: 36 (29 generated)
bbudge
+gdeepti for x64. +aseemgarg for SIMD scalar lowering. +dusan.simicic for MIPS. +bmeurer, bradnelson for the ...
3 years, 6 months ago (2017-06-05 17:11:49 UTC) #9
bbudge
This simplification will bring us into line with Mozilla, and the rough consensus at the ...
3 years, 6 months ago (2017-06-07 02:24:45 UTC) #23
Benedikt Meurer
Nice! Remove all the boolean vectors! :-) LGTM from my side.
3 years, 6 months ago (2017-06-07 03:54:48 UTC) #24
dusan.simicic
lgtm for mips part
3 years, 6 months ago (2017-06-07 09:40:07 UTC) #25
bradnelson
lgtm on wasm ops.
3 years, 6 months ago (2017-06-07 14:40:46 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919203002/140001
3 years, 6 months ago (2017-06-08 20:25:40 UTC) #33
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 20:54:44 UTC) #36
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/381f7da02c4d8a641f329d23e06f99d7c75...

Powered by Google App Engine
This is Rietveld 408576698