Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 2916363002: [inspector] Make pausing on console.assert work with multiple sessions (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Make pausing on console.assert work with multiple sessions Instead of going through debugger agent, this patch implements console.assert pause similar to debugger statement and OOM break. New test uncovered a bug, where pause on exceptions state mix up between different context groups. Added a TODO to fix it. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916363002 Cr-Commit-Position: refs/heads/master@{#45711} Committed: https://chromium.googlesource.com/v8/v8/+/f5767bf6c4eb693a1a754f27230300a2a1c1d72b

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -24 lines) Patch
M src/inspector/v8-console.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/inspector/v8-debugger.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/inspector/v8-debugger.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 4 chunks +6 lines, -10 lines 0 comments Download
A test/inspector/sessions/pause-on-console-assert.js View 1 chunk +54 lines, -0 lines 0 comments Download
A test/inspector/sessions/pause-on-console-assert-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dgozman
Alexei, could you please take a look?
3 years, 6 months ago (2017-06-02 18:19:56 UTC) #2
kozy
thanks, lgtm
3 years, 6 months ago (2017-06-03 11:08:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916363002/20001
3 years, 6 months ago (2017-06-05 18:39:38 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 18:41:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f5767bf6c4eb693a1a754f27230300a2a1c...

Powered by Google App Engine
This is Rietveld 408576698