Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: src/inspector/v8-console.cc

Issue 2916363002: [inspector] Make pausing on console.assert work with multiple sessions (Closed)
Patch Set: rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-console.cc
diff --git a/src/inspector/v8-console.cc b/src/inspector/v8-console.cc
index 8b1ab62c41c1437827c1d36b990a74223ef1f03c..a15444882aba66c8fe847cd0666cededf48679d2 100644
--- a/src/inspector/v8-console.cc
+++ b/src/inspector/v8-console.cc
@@ -275,14 +275,7 @@ void V8Console::Assert(const v8::debug::ConsoleCallArguments& info) {
arguments.push_back(
toV8String(m_inspector->isolate(), String16("console.assert")));
helper.reportCall(ConsoleAPIType::kAssert, arguments);
-
- // TODO(dgozman): only break once, not per each session.
- helper.forEachSession([](V8InspectorSessionImpl* session) {
- if (session->debuggerAgent()->enabled()) {
- session->debuggerAgent()->breakProgramOnException(
- protocol::Debugger::Paused::ReasonEnum::Assert, nullptr);
- }
- });
+ m_inspector->debugger()->breakProgramOnAssert(helper.groupId());
}
void V8Console::MarkTimeline(const v8::debug::ConsoleCallArguments& info) {
« no previous file with comments | « no previous file | src/inspector/v8-debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698