[inspector] Create InjectedScript per session in each context

[inspector] Create InjectedScript per session in each context

This gives sessions separate remote objects space and also
makes command line api respect the session it was called from.

BUG=chromium:590878
Review-Url: https://codereview.chromium.org/2916803005
Cr-Commit-Position: refs/heads/master@{#45708}
Committed: https://chromium.googlesource.com/v8/v8/+/b5e81c7ccf304407190ebd4dcfef2388c447d7a0

[dgozman, 2017-06-02 02:15:44]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2017-06-02 02:15:44]

Could you please take a look?

[dgozman, 2017-06-02 02:15:49]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 02:15:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 02:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 02:44:01]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-06-03 11:16:15]

lgtm

https://codereview.chromium.org/2916803005/diff/1/src/inspector/inspected-con...
File src/inspector/inspected-context.h (right):

https://codereview.chromium.org/2916803005/diff/1/src/inspector/inspected-con...
src/inspector/inspected-context.h:42: InjectedScript* getAnyInjectedScript() {
Who use this method?

https://codereview.chromium.org/2916803005/diff/1/src/inspector/v8-console.cc
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2916803005/diff/1/src/inspector/v8-console.cc...
src/inspector/v8-console.cc:592: v8::External::New(isolate, new
CommandLineAPIData(this, sessionId));
We can expose class PodArray for inspector from objects.h and use it here to
avoid leak.

[dgozman, 2017-06-05 17:08:11]

https://codereview.chromium.org/2916803005/diff/1/src/inspector/inspected-con...
File src/inspector/inspected-context.h (right):

https://codereview.chromium.org/2916803005/diff/1/src/inspector/inspected-con...
src/inspector/inspected-context.h:42: InjectedScript* getAnyInjectedScript() {
On 2017/06/03 11:16:15, kozy wrote:
> Who use this method?

Left-over from partial testing :-) Removed.

https://codereview.chromium.org/2916803005/diff/1/src/inspector/v8-console.cc
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2916803005/diff/1/src/inspector/v8-console.cc...
src/inspector/v8-console.cc:592: v8::External::New(isolate, new
CommandLineAPIData(this, sessionId));
On 2017/06/03 11:16:15, kozy wrote:
> We can expose class PodArray for inspector from objects.h and use it here to
> avoid leak.

Added a TODO for that.

[dgozman, 2017-06-05 17:08:17]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-05 17:08:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2916803005/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-05 17:08:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:37:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496682497257600,
"parent_rev": "3965c5487919c01fa8aee6bc0faed400ba1e8440", "commit_rev":
"b5e81c7ccf304407190ebd4dcfef2388c447d7a0"}

[commit-bot: I haz the power, 2017-06-05 17:37:33]

Description was changed from

==========
[inspector] Create InjectedScript per session in each context

This gives sessions separate remote objects space and also
makes command line api respect the session it was called from.

BUG=chromium:590878
==========

to

==========
[inspector] Create InjectedScript per session in each context

This gives sessions separate remote objects space and also
makes command line api respect the session it was called from.

BUG=chromium:590878

Review-Url: https://codereview.chromium.org/2916803005
Cr-Commit-Position: refs/heads/master@{#45708}
Committed:
https://chromium.googlesource.com/v8/v8/+/b5e81c7ccf304407190ebd4dcfef2388c44...
==========

[commit-bot: I haz the power, 2017-06-05 17:37:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b5e81c7ccf304407190ebd4dcfef2388c44...