Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2921373002: [inspector] Test how multiple sessions interact with pausing (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Test how multiple sessions interact with pausing Found multiple issues (added TODOs for them): - isPaused() check is global, so one can resume from another session/context group without receiving 'paused' notification; - setBreakpointsActive flag is global affecting all sessions and context groups; - max async call stack depth is global, and should be per context group. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2921373002 Cr-Commit-Position: refs/heads/master@{#45742} Committed: https://chromium.googlesource.com/v8/v8/+/579c1e2976efdae7416ce670b12c8a6365695f05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -1 line) Patch
M src/inspector/v8-debugger.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 2 chunks +6 lines, -1 line 0 comments Download
A test/inspector/sessions/debugger-stepping-and-breakpoints.js View 1 chunk +172 lines, -0 lines 0 comments Download
A test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt View 1 chunk +190 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 6 months ago (2017-06-05 23:45:03 UTC) #2
kozy
lgtm
3 years, 6 months ago (2017-06-06 17:06:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921373002/1
3 years, 6 months ago (2017-06-06 17:07:55 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 17:09:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/579c1e2976efdae7416ce670b12c8a63656...

Powered by Google App Engine
This is Rietveld 408576698