Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2920313002:
[inspector] Test how Profiler interacts with multiple sessions (Closed)
Description[inspector] Test how Profiler interacts with multiple sessions
BUG=chromium:590878
Review-Url: https://codereview.chromium.org/2920313002
Cr-Original-Commit-Position: refs/heads/master@{#45715}
Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4657a6
Review-Url: https://codereview.chromium.org/2920313002
Cr-Commit-Position: refs/heads/master@{#45717}
Committed: https://chromium.googlesource.com/v8/v8/+/679604bdd2991a19cadf7ab5c462fc6f368f32fc
Patch Set 1 #
Total comments: 6
Patch Set 2 : parens #Patch Set 3 : unflake #
Messages
Total messages: 21 (10 generated)
dgozman@chromium.org changed reviewers: + alph@chromium.org
Could you please take a look?
lgtm https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... File test/inspector/sessions/cpu-profile.js (right): https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:18: var foundFoo = profile.nodes.some(node => node.callFrame.functionName === 'foo'); FYI: This has some probability of flaking, as there's a chance no samples land onto foo. https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:40: checkProfile((message).result.profile); drop () https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:45: checkProfile((message).result.profile); drop ()
https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... File test/inspector/sessions/cpu-profile.js (right): https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:18: var foundFoo = profile.nodes.some(node => node.callFrame.functionName === 'foo'); On 2017/06/05 21:10:41, alph wrote: > FYI: This has some probability of flaking, as there's a chance no samples land > onto foo. Thanks! I'm staying positive though :) https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:40: checkProfile((message).result.profile); On 2017/06/05 21:10:41, alph wrote: > drop () Done. https://codereview.chromium.org/2920313002/diff/1/test/inspector/sessions/cpu... test/inspector/sessions/cpu-profile.js:45: checkProfile((message).result.profile); On 2017/06/05 21:10:40, alph wrote: > drop () Done.
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org Link to the patchset: https://codereview.chromium.org/2920313002/#ps10003 (title: "parens")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 10003, "attempt_start_ts": 1496699469730860,
"parent_rev": "911528847ccfded02b8c04c51d1381322e2f34a5", "commit_rev":
"754f81e20e9e7abfb3ce82e73a3389a72f4657a6"}
Message was sent while issue was closed.
Description was changed from ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 ========== to ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:10003) as https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10003) has been created in https://codereview.chromium.org/2928493002/ by mtrofin@chromium.org. The reason for reverting is: Bot failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds....
Message was sent while issue was closed.
Description was changed from ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4... ========== to ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4... ==========
For the record: this did flake, so relaxing the test to unflake it.
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org Link to the patchset: https://codereview.chromium.org/2920313002/#ps30001 (title: "unflake")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 30001, "attempt_start_ts": 1496706544130550,
"parent_rev": "5bba0d1a0bb44edaae87e772607ec0ab03e01988", "commit_rev":
"679604bdd2991a19cadf7ab5c462fc6f368f32fc"}
Message was sent while issue was closed.
Description was changed from ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4... ========== to ========== [inspector] Test how Profiler interacts with multiple sessions BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2920313002 Cr-Original-Commit-Position: refs/heads/master@{#45715} Committed: https://chromium.googlesource.com/v8/v8/+/754f81e20e9e7abfb3ce82e73a3389a72f4... Review-Url: https://codereview.chromium.org/2920313002 Cr-Commit-Position: refs/heads/master@{#45717} Committed: https://chromium.googlesource.com/v8/v8/+/679604bdd2991a19cadf7ab5c462fc6f368... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as https://chromium.googlesource.com/v8/v8/+/679604bdd2991a19cadf7ab5c462fc6f368...
Message was sent while issue was closed.
Note, this still fails in full-debug mode (ie non-optimized): https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20full%20debug...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:30001) has been created in https://codereview.chromium.org/2926533003/ by dgozman@chromium.org. The reason for reverting is: DCHECKS triggering in debug build.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
