Split HttpNetworkSession::Params into two structs.

Split HttpNetworkSession::Params into two structs.

Context contains the raw pointers to unowned objects, while Params
contains the inline declared objects, so it's safely copiable.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653, 715695
Review-Url: https://codereview.chromium.org/2907463002
Cr-Commit-Position: refs/heads/master@{#476044}
Committed: https://chromium.googlesource.com/chromium/src/+/6ddfbead4aad126ef4fef58346ef11ff94a7d2e7

[mmenke, 2017-05-24 22:39:14]

Description was changed from

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.
==========

to

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.
==========

[mmenke, 2017-05-25 14:44:08]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 14:44:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 14:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 14:46:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-05-25 20:42:38]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 20:43:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:48:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-05-25 21:08:41]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:09:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 21:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:22:17]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mmenke, 2017-05-25 21:35:16]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:35:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-25 21:39:51]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-05-25 21:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:48:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mmenke, 2017-05-25 21:57:58]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:59:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 22:10:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-05-26 15:46:30]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 15:46:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:58:37]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-05-26 16:04:43]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 16:05:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-26 16:31:02]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2017-05-26 16:31:03]

Had planned to bulk up URLRequestContextBuilder::HttpNetworksessionParams, but
it started just getting silly.  Instead, this CL will allow us to replace it
with HttpNetworksession::Params, at the cost of some ugliness due splitting
Params in two.  I *hope* that we can move most classes off of constructing their
own HttpNetworkSessions manually, and have them use the URLRequestContextBuilder
instead, but there's no guarantee of that.

Also, note that this sits on top of several other (Mostly reviewed) unlanded
CLs.  To review, I suggest you start with http_network_session.*.  Most other
changes are pretty self-contained; there are just a lot of them.  :(  I don't
think there's a good way to break this into multiple CLs, unfortunately.

[mmenke, 2017-05-26 16:42:42]

Description was changed from

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.
==========

to

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=715695
==========

[mmenke, 2017-05-26 16:43:04]

Description was changed from

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=715695
==========

to

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653,715695
==========

[commit-bot: I haz the power, 2017-05-26 17:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:42:44]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mmenke, 2017-05-30 18:02:30]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 18:03:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 18:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:14:39]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[mmenke, 2017-05-30 18:16:39]

Expect tryjobs to fail here - I've merged this 3 times to keep up with code
changes, another CL with conflicts is currently in the CQ, and it looks like
another CL modified quic tests in the meantime, again causing a failure.  :(

[mmenke, 2017-05-30 18:27:55]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 18:28:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 20:44:05]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-05-31 18:09:40]

LGTM modulo your evaluation of the one point below.  

(Such a large amount of reading for such a small number of comments :-}.)

https://codereview.chromium.org/2907463002/diff/190001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_unittest.cc (left):

https://codereview.chromium.org/2907463002/diff/190001/net/http/http_stream_f...
net/http/http_stream_factory_impl_unittest.cc:1119:
params.http_server_properties = &http_server_properties;
Why doesn't this need to be moved over to the session context?

[Randy Smith (Not in Mondays), 2017-05-31 18:15:05]

Actually, one other request: Could you update the CL description so it's clear
that "A bunch of owned objects" means inlined declared rather than
std::unique_ptr<>?  The point is that they're all copyable, so it's perfectly
fine to just create new contexts from someone else's params; that confused me on
my first read through for a little bit.

[mmenke, 2017-05-31 18:48:45]

Description was changed from

==========
Split HttpNetworkSession::Params into two structs.

Context contains a bunch of raw pointers to unowned objects.  Params
contains a bunch of POD types and a couple owned objects.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653,715695
==========

to

==========
Split HttpNetworkSession::Params into two structs.

Context contains the raw pointers to unowned objects, while Params
contains the inline declared objects, so it's safely copiable.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653,715695
==========

[mmenke, 2017-05-31 18:57:19]

Thanks so much for the review!  Know it can't have been fun.

https://codereview.chromium.org/2907463002/diff/190001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_unittest.cc (left):

https://codereview.chromium.org/2907463002/diff/190001/net/http/http_stream_f...
net/http/http_stream_factory_impl_unittest.cc:1119:
params.http_server_properties = &http_server_properties;
On 2017/05/31 18:09:40, Randy Smith (Not in Mondays) wrote:
> Why doesn't this need to be moved over to the session context?

This is a bug, nice catch!  Fixed.

[mmenke, 2017-05-31 18:57:32]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:58:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-31 19:06:38]

mmenke@chromium.org changed reviewers:
+ halliwell@chromium.org, mattm@chromium.org, mkwst@chromium.org,
rohitrao@chromium.org, zea@chromium.org

[mmenke, 2017-05-31 19:06:39]

[+halliwell]:  Please review chromecast/
[+zea]:  Please review components/gcm_driver/, google_apis/gcm/tools/, and
jingle/glue/
[+mattm]:  Please review components/safe_browsing/
[+mkwst]:  Please review content/shell/
[+rohitrao]:  Please review ios/

Thanks!

Most of these consumers really should be switched over to using
URLRequestContextBuilder, at some point, so they don't have to go through the
complexity of setting up everything themselves - I may switch some over myself,
some day, but no promises.

[halliwell, 2017-05-31 19:08:46]

On 2017/05/31 19:06:39, mmenke wrote:
> [+halliwell]:  Please review chromecast/
> [+zea]:  Please review components/gcm_driver/, google_apis/gcm/tools/, and
> jingle/glue/
> [+mattm]:  Please review components/safe_browsing/
> [+mkwst]:  Please review content/shell/
> [+rohitrao]:  Please review ios/
> 
> Thanks!
> 
> Most of these consumers really should be switched over to using
> URLRequestContextBuilder, at some point, so they don't have to go through the
> complexity of setting up everything themselves - I may switch some over
myself,
> some day, but no promises.

chromecast/ lgtm

[mattm, 2017-05-31 19:30:37]

safe_browsing lgtm

[rohitrao (ping after 24h), 2017-05-31 19:39:48]

ios/ lgtm

[Mike West, 2017-05-31 19:55:28]

//content/shell LGTM

[Nicolas Zea, 2017-05-31 19:56:29]

gcm lgtm

[Nicolas Zea, 2017-05-31 19:57:15]

Oops, forgot to say jingle also lgtm

[mmenke, 2017-05-31 19:59:01]

On 2017/05/31 19:57:15, Nicolas Zea wrote:
> Oops, forgot to say jingle also lgtm

Thanks for the speed reviews, everyone!  Very much appreciated.

[mmenke, 2017-05-31 19:59:12]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-05-31 19:59:26]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-05-31 19:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/2907463002/#ps230001
(title: "Response to comments")

[commit-bot: I haz the power, 2017-05-31 20:00:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-31 20:59:12]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-05-31 20:59:28]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-31 20:59:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1496264368954620,
"parent_rev": "1ad46b56059a2f74da00d4c42e604a2090712a73", "commit_rev":
"a076c7c52893e57e53d6bddcb8ba325763ec4866"}

[commit-bot: I haz the power, 2017-05-31 21:48:58]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1496264368954620,
"parent_rev": "c9a6e48daa1618e9c65b17b872ec8ad1926400ab", "commit_rev":
"6ddfbead4aad126ef4fef58346ef11ff94a7d2e7"}

[commit-bot: I haz the power, 2017-05-31 21:49:10]

Description was changed from

==========
Split HttpNetworkSession::Params into two structs.

Context contains the raw pointers to unowned objects, while Params
contains the inline declared objects, so it's safely copiable.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653,715695
==========

to

==========
Split HttpNetworkSession::Params into two structs.

Context contains the raw pointers to unowned objects, while Params
contains the inline declared objects, so it's safely copiable.

The goal is to replace URLRequestContextBuilder::HttpNetworkSessionParams
with HttpNetworkSession::Params, as the former is a subset of the latter,
and needs to grow to encompass most of them, anyways, before we can
use URLRequestContextBuilder to build the main URLRequestContexts.

BUG=725653,715695

Review-Url: https://codereview.chromium.org/2907463002
Cr-Commit-Position: refs/heads/master@{#476044}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ddfbead4aad126ef4fef58346ef...
==========

[commit-bot: I haz the power, 2017-05-31 21:49:12]

Committed patchset #12 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/6ddfbead4aad126ef4fef58346ef...