Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: net/http/http_network_layer_unittest.cc

Issue 2907463002: Split HttpNetworkSession::Params into two structs. (Closed)
Patch Set: Response to comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_network_layer.h" 5 #include "net/http/http_network_layer.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "net/cert/ct_policy_enforcer.h" 10 #include "net/cert/ct_policy_enforcer.h"
(...skipping 26 matching lines...) Expand all
37 HttpNetworkLayerTest() : ssl_config_service_(new SSLConfigServiceDefaults) {} 37 HttpNetworkLayerTest() : ssl_config_service_(new SSLConfigServiceDefaults) {}
38 38
39 void SetUp() override { 39 void SetUp() override {
40 ConfigureTestDependencies(ProxyService::CreateDirect()); 40 ConfigureTestDependencies(ProxyService::CreateDirect());
41 } 41 }
42 42
43 void ConfigureTestDependencies(std::unique_ptr<ProxyService> proxy_service) { 43 void ConfigureTestDependencies(std::unique_ptr<ProxyService> proxy_service) {
44 cert_verifier_.reset(new MockCertVerifier); 44 cert_verifier_.reset(new MockCertVerifier);
45 transport_security_state_.reset(new TransportSecurityState); 45 transport_security_state_.reset(new TransportSecurityState);
46 proxy_service_ = std::move(proxy_service); 46 proxy_service_ = std::move(proxy_service);
47 HttpNetworkSession::Params session_params; 47 HttpNetworkSession::Context session_context;
48 session_params.client_socket_factory = &mock_socket_factory_; 48 session_context.client_socket_factory = &mock_socket_factory_;
49 session_params.host_resolver = &host_resolver_; 49 session_context.host_resolver = &host_resolver_;
50 session_params.cert_verifier = cert_verifier_.get(); 50 session_context.cert_verifier = cert_verifier_.get();
51 session_params.transport_security_state = transport_security_state_.get(); 51 session_context.transport_security_state = transport_security_state_.get();
52 session_params.cert_transparency_verifier = &ct_verifier_; 52 session_context.cert_transparency_verifier = &ct_verifier_;
53 session_params.ct_policy_enforcer = &ct_policy_enforcer_; 53 session_context.ct_policy_enforcer = &ct_policy_enforcer_;
54 session_params.proxy_service = proxy_service_.get(); 54 session_context.proxy_service = proxy_service_.get();
55 session_params.ssl_config_service = ssl_config_service_.get(); 55 session_context.ssl_config_service = ssl_config_service_.get();
56 session_params.http_server_properties = &http_server_properties_; 56 session_context.http_server_properties = &http_server_properties_;
57 network_session_.reset(new HttpNetworkSession(session_params)); 57 network_session_.reset(
58 new HttpNetworkSession(HttpNetworkSession::Params(), session_context));
58 factory_.reset(new HttpNetworkLayer(network_session_.get())); 59 factory_.reset(new HttpNetworkLayer(network_session_.get()));
59 } 60 }
60 61
61 void ExecuteRequestExpectingContentAndHeader(const std::string& method, 62 void ExecuteRequestExpectingContentAndHeader(const std::string& method,
62 const std::string& content, 63 const std::string& content,
63 const std::string& header, 64 const std::string& header,
64 const std::string& value) { 65 const std::string& value) {
65 TestCompletionCallback callback; 66 TestCompletionCallback callback;
66 67
67 HttpRequestInfo request_info; 68 HttpRequestInfo request_info;
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 rv = trans->Start(&request_info, callback.callback(), NetLogWithSource()); 407 rv = trans->Start(&request_info, callback.callback(), NetLogWithSource());
407 ASSERT_THAT(callback.GetResult(rv), IsError(ERR_CONNECTION_RESET)); 408 ASSERT_THAT(callback.GetResult(rv), IsError(ERR_CONNECTION_RESET));
408 409
409 // network_accessed is true; the HTTP stack did try to make a connection. 410 // network_accessed is true; the HTTP stack did try to make a connection.
410 EXPECT_TRUE(trans->GetResponseInfo()->network_accessed); 411 EXPECT_TRUE(trans->GetResponseInfo()->network_accessed);
411 } 412 }
412 413
413 } // namespace 414 } // namespace
414 415
415 } // namespace net 416 } // namespace net
OLDNEW
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698