Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: net/url_request/url_request_test_util.cc

Issue 2907463002: Split HttpNetworkSession::Params into two structs. (Closed)
Patch Set: Response to comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_test_util.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_test_util.h" 5 #include "net/url_request/url_request_test_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 // In-memory Channel ID service. Must be created before the 107 // In-memory Channel ID service. Must be created before the
108 // HttpNetworkSession. 108 // HttpNetworkSession.
109 if (!channel_id_service()) { 109 if (!channel_id_service()) {
110 context_storage_.set_channel_id_service( 110 context_storage_.set_channel_id_service(
111 base::MakeUnique<ChannelIDService>(new DefaultChannelIDStore(nullptr))); 111 base::MakeUnique<ChannelIDService>(new DefaultChannelIDStore(nullptr)));
112 } 112 }
113 if (http_transaction_factory()) { 113 if (http_transaction_factory()) {
114 // Make sure we haven't been passed an object we're not going to use. 114 // Make sure we haven't been passed an object we're not going to use.
115 EXPECT_FALSE(client_socket_factory_); 115 EXPECT_FALSE(client_socket_factory_);
116 } else { 116 } else {
117 HttpNetworkSession::Params params; 117 HttpNetworkSession::Params session_params;
118 if (http_network_session_params_)
119 session_params = *http_network_session_params_;
118 120
119 if (http_network_session_params_) 121 HttpNetworkSession::Context session_context;
120 params = *http_network_session_params_; 122 if (http_network_session_context_)
121 params.client_socket_factory = client_socket_factory(); 123 session_context = *http_network_session_context_;
122 params.proxy_delegate = proxy_delegate(); 124 session_context.client_socket_factory = client_socket_factory();
123 params.host_resolver = host_resolver(); 125 session_context.proxy_delegate = proxy_delegate();
124 params.cert_verifier = cert_verifier(); 126 session_context.host_resolver = host_resolver();
125 params.cert_transparency_verifier = cert_transparency_verifier(); 127 session_context.cert_verifier = cert_verifier();
126 params.ct_policy_enforcer = ct_policy_enforcer(); 128 session_context.cert_transparency_verifier = cert_transparency_verifier();
127 params.transport_security_state = transport_security_state(); 129 session_context.ct_policy_enforcer = ct_policy_enforcer();
128 params.proxy_service = proxy_service(); 130 session_context.transport_security_state = transport_security_state();
129 params.ssl_config_service = ssl_config_service(); 131 session_context.proxy_service = proxy_service();
130 params.http_auth_handler_factory = http_auth_handler_factory(); 132 session_context.ssl_config_service = ssl_config_service();
131 params.http_server_properties = http_server_properties(); 133 session_context.http_auth_handler_factory = http_auth_handler_factory();
132 params.net_log = net_log(); 134 session_context.http_server_properties = http_server_properties();
133 params.channel_id_service = channel_id_service(); 135 session_context.net_log = net_log();
136 session_context.channel_id_service = channel_id_service();
134 context_storage_.set_http_network_session( 137 context_storage_.set_http_network_session(
135 base::MakeUnique<HttpNetworkSession>(params)); 138 base::MakeUnique<HttpNetworkSession>(session_params, session_context));
136 context_storage_.set_http_transaction_factory(base::MakeUnique<HttpCache>( 139 context_storage_.set_http_transaction_factory(base::MakeUnique<HttpCache>(
137 context_storage_.http_network_session(), 140 context_storage_.http_network_session(),
138 HttpCache::DefaultBackend::InMemory(0), true /* is_main_cache */)); 141 HttpCache::DefaultBackend::InMemory(0), true /* is_main_cache */));
139 } 142 }
140 if (!http_user_agent_settings()) { 143 if (!http_user_agent_settings()) {
141 context_storage_.set_http_user_agent_settings( 144 context_storage_.set_http_user_agent_settings(
142 base::MakeUnique<StaticHttpUserAgentSettings>("en-us,fr", 145 base::MakeUnique<StaticHttpUserAgentSettings>("en-us,fr",
143 std::string())); 146 std::string()));
144 } 147 }
145 if (!job_factory()) { 148 if (!job_factory()) {
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 NetworkDelegate* network_delegate) const { 678 NetworkDelegate* network_delegate) const {
676 return main_intercept_job_.release(); 679 return main_intercept_job_.release();
677 } 680 }
678 681
679 void TestJobInterceptor::set_main_intercept_job( 682 void TestJobInterceptor::set_main_intercept_job(
680 std::unique_ptr<URLRequestJob> job) { 683 std::unique_ptr<URLRequestJob> job) {
681 main_intercept_job_ = std::move(job); 684 main_intercept_job_ = std::move(job);
682 } 685 }
683 686
684 } // namespace net 687 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_test_util.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698