Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: net/url_request/url_request_test_util.h

Issue 2907463002: Split HttpNetworkSession::Params into two structs. (Closed)
Patch Set: Response to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_quic_unittest.cc ('k') | net/url_request/url_request_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_test_util.h
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h
index 9868bcbb2e43d7c14a307cd152d5c4ef531ba253..ebd9aad289ccb12d0fe8104e98fcf134645feeea 100644
--- a/net/url_request/url_request_test_util.h
+++ b/net/url_request/url_request_test_util.h
@@ -77,8 +77,13 @@ class TestURLRequestContext : public URLRequestContext {
}
void set_http_network_session_params(
- std::unique_ptr<HttpNetworkSession::Params> params) {
- http_network_session_params_ = std::move(params);
+ std::unique_ptr<HttpNetworkSession::Params> session_params) {
+ http_network_session_params_ = std::move(session_params);
+ }
+
+ void set_http_network_session_context(
+ std::unique_ptr<HttpNetworkSession::Context> session_context) {
+ http_network_session_context_ = std::move(session_context);
}
void SetSdchManager(std::unique_ptr<SdchManager> sdch_manager) {
@@ -93,10 +98,11 @@ class TestURLRequestContext : public URLRequestContext {
private:
bool initialized_ = false;
- // Optional parameters to override default values. Note that values that
- // point to other objects the TestURLRequestContext creates will be
- // overwritten.
+ // Optional parameters to override default values. Note that values in the
+ // HttpNetworkSession::Context that point to other objects the
+ // TestURLRequestContext creates will be overwritten.
std::unique_ptr<HttpNetworkSession::Params> http_network_session_params_;
+ std::unique_ptr<HttpNetworkSession::Context> http_network_session_context_;
// Not owned:
ClientSocketFactory* client_socket_factory_ = nullptr;
« no previous file with comments | « net/url_request/url_request_quic_unittest.cc ('k') | net/url_request/url_request_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698