Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 2907463002: Split HttpNetworkSession::Params into two structs. (Closed)
Patch Set: Response to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_browsertest.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index 7a039d6cb1c93716575984defa2d42d193e6b1b1..a6eebb3faac12cc562cd7720111d6cbb738b10c5 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -651,15 +651,17 @@ net::URLRequestContext* ProfileImplIOData::InitializeAppRequestContext(
cookie_store->SetChannelIDServiceID(channel_id_service->GetUniqueID());
// Build a new HttpNetworkSession that uses the new ChannelIDService.
- // TODO(mmenke): It weird to combine state from
+ // TODO(mmenke): It's weird to combine state from
// main_request_context_storage() objects and the argumet to this method,
// |main_context|. Remove |main_context| as an argument, and just use
// main_context() instead.
- net::HttpNetworkSession::Params network_params =
- main_request_context_storage()->http_network_session()->params();
- network_params.channel_id_service = channel_id_service.get();
+ net::HttpNetworkSession::Context session_context =
+ main_request_context_storage()->http_network_session()->context();
+ session_context.channel_id_service = channel_id_service.get();
std::unique_ptr<net::HttpNetworkSession> http_network_session(
- new net::HttpNetworkSession(network_params));
+ new net::HttpNetworkSession(
+ main_request_context_storage()->http_network_session()->params(),
+ session_context));
std::unique_ptr<net::HttpCache> app_http_cache =
CreateMainHttpFactory(http_network_session.get(), std::move(app_backend));
« no previous file with comments | « chrome/browser/profiles/profile_browsertest.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698