blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Add missing check for WeakMember<> fields in non-managed classes;
not permitted just like Member<>.

R=dcheng,haraken
BUG=724418
Review-Url: https://codereview.chromium.org/2902563002
Cr-Commit-Position: refs/heads/master@{#474368}
Committed: https://chromium.googlesource.com/chromium/src/+/55a04e9c19f6754fad6f509cf6854dd35c896071

[sof, 2017-05-22 18:43:44]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:44:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-05-22 18:45:25]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:45:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-05-22 18:48:09]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, oilpan-reviews@chromium.org

[sof, 2017-05-22 18:48:09]

please take a look.

Depends on https://crbug.com/724418#c6 being addressed (the only place where
this WeakMember<> check triggers atm.)

[commit-bot: I haz the power, 2017-05-22 18:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:59:20]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-05-22 21:25:49]

LGTM

[haraken, 2017-05-22 23:57:24]

LGTM

[sof, 2017-05-23 05:52:58]

Great, thanks for doing https://chromium-review.googlesource.com/509149 right
away.

I suggest we land this blink GC plugin right now, without it being behind a flag
(as per normal procedure for any functional & user-visible change to the GC
plugin.)

[dcheng, 2017-05-23 06:19:10]

On 2017/05/23 05:52:58, sof wrote:
> Great, thanks for doing https://chromium-review.googlesource.com/509149 right
> away.
> 
> I suggest we land this blink GC plugin right now, without it being behind a
flag
> (as per normal procedure for any functional & user-visible change to the GC
> plugin.)

Given that there was only one failure, I guess it's unlikely for this to break
in the near future, we'll still have to roll the plugin. You might want to give
up a heads up to thakis/hans.

[sof, 2017-05-23 06:57:36]

I would agree with that (land enabled, but watch out for the next roll), but I'm
not sure the extended Cc: list will be on board.. :)

Accidental WeakMember<> references being left around when pulling a class off
the Blink GC heap (which seems to be what happened), is a rather unusual case.

[Nico, 2017-05-23 14:11:36]

If you're very confident that this won't regress in the next few weeks, you can
add it with-a-flag-but-on-by-default. That saves you some churn and gives us an
escape hatch if we need it.

[sof, 2017-05-23 21:06:46]

On 2017/05/23 14:11:36, Nico wrote:
> If you're very confident that this won't regress in the next few weeks, you
can
> add it with-a-flag-but-on-by-default. That saves you some churn and gives us
an
> escape hatch if we need it.

I think the accidental breakage potential is low for this one, so that sounds
reasonable to me. Added.

[sof, 2017-05-23 21:08:55]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 21:10:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:34:28]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-05-24 00:24:20]

lgtm

[sof, 2017-05-24 06:56:36]

Description was changed from

==========
blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Add missing check for WeakMember<> fields in non-managed classes;
not permitted just like Member<>.

R=
BUG=724418
==========

to

==========
blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Add missing check for WeakMember<> fields in non-managed classes;
not permitted just like Member<>.

R=dcheng,haraken
BUG=724418
==========

[sof, 2017-05-24 18:29:57]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-05-24 18:29:58]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2902563002/#ps60001
(title: "add missing file from ps#3")

[commit-bot: I haz the power, 2017-05-24 18:30:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495650597782990,
"parent_rev": "c2465e8818793d5c18eb7bf3f1bd20b85414cb96", "commit_rev":
"55a04e9c19f6754fad6f509cf6854dd35c896071"}

[commit-bot: I haz the power, 2017-05-24 18:37:35]

Description was changed from

==========
blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Add missing check for WeakMember<> fields in non-managed classes;
not permitted just like Member<>.

R=dcheng,haraken
BUG=724418
==========

to

==========
blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Add missing check for WeakMember<> fields in non-managed classes;
not permitted just like Member<>.

R=dcheng,haraken
BUG=724418

Review-Url: https://codereview.chromium.org/2902563002
Cr-Commit-Position: refs/heads/master@{#474368}
Committed:
https://chromium.googlesource.com/chromium/src/+/55a04e9c19f6754fad6f509cf685...
==========

[commit-bot: I haz the power, 2017-05-24 18:37:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/55a04e9c19f6754fad6f509cf685...