tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp - Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects. (Closed)

Patch Set: add missing file from ps#3 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

index a770f8263e2fefb034eccb12ad96ee693f2f321b..e45ccf8db6eb1e9d5b95ec6b4947fe5987eb55a3 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

@@ -195,7 +195,7 @@ void BlinkGCPluginConsumer::CheckClass(RecordInfo* info) {

}

{

- CheckFieldsVisitor visitor;

+ CheckFieldsVisitor visitor(options_);

if (visitor.ContainsInvalidFields(info))

reporter_.ClassContainsInvalidFields(info, visitor.invalid_fields());

}