tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h - Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects. (Closed)

Patch Set: add missing file from ps#3 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

diff --git a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h b/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

index 89357a3482e7c8ed1a5e2befdbddf6260a182378..170a889028cf446ff611407685b586615facd8bc 100644

--- a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

+++ b/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

@@ -16,6 +16,7 @@ public:

void Trace(Visitor*);

private:

Member<HeapObject> m_obj; // Must not contain Member.

+ WeakMember<HeapObject> m_weak; // Must not contain WeakMember.

Persistent<HeapVector<Member<HeapObject> > > m_objs; // OK

};