Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt

Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects. (Closed)
Patch Set: add missing file from ps#3 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from member_in_offheap_class.cpp:5: 1 In file included from member_in_offheap_class.cpp:5:
2 ./member_in_offheap_class.h:14:1: warning: [blink-gc] Class 'OffHeapObject' cont ains invalid fields. 2 ./member_in_offheap_class.h:14:1: warning: [blink-gc] Class 'OffHeapObject' cont ains invalid fields.
3 class OffHeapObject { 3 class OffHeapObject {
4 ^ 4 ^
5 ./member_in_offheap_class.h:18:5: note: [blink-gc] Member field 'm_obj' in unman aged class declared here: 5 ./member_in_offheap_class.h:18:5: note: [blink-gc] Member field 'm_obj' in unman aged class declared here:
6 Member<HeapObject> m_obj; // Must not contain Member. 6 Member<HeapObject> m_obj; // Must not contain Member.
7 ^ 7 ^
8 ./member_in_offheap_class.h:22:1: warning: [blink-gc] Class 'StackObject' contai ns invalid fields. 8 ./member_in_offheap_class.h:19:5: note: [blink-gc] Member field 'm_weak' in unma naged class declared here:
9 WeakMember<HeapObject> m_weak; // Must not contain WeakMember.
10 ^
11 ./member_in_offheap_class.h:23:1: warning: [blink-gc] Class 'StackObject' contai ns invalid fields.
9 class StackObject { 12 class StackObject {
10 ^ 13 ^
11 ./member_in_offheap_class.h:26:5: note: [blink-gc] Member field 'm_memberOff' to non-GC managed class declared here: 14 ./member_in_offheap_class.h:27:5: note: [blink-gc] Member field 'm_memberOff' to non-GC managed class declared here:
12 Member<OffHeapObject> m_memberOff; // NOT OK 15 Member<OffHeapObject> m_memberOff; // NOT OK
13 ^ 16 ^
14 ./member_in_offheap_class.h:27:5: note: [blink-gc] Member field 'm_heapVectorMem berOff' to non-GC managed class declared here: 17 ./member_in_offheap_class.h:28:5: note: [blink-gc] Member field 'm_heapVectorMem berOff' to non-GC managed class declared here:
15 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK 18 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK
16 ^ 19 ^
17 2 warnings generated. 20 2 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698