Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

Issue 2902563002: blink_gc_plugin: disallow WeakMember<> fields in off-heap objects. (Closed)
Patch Set: add missing file from ps#3 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEMBER_IN_OFFHEAP_CLASS_H_ 5 #ifndef MEMBER_IN_OFFHEAP_CLASS_H_
6 #define MEMBER_IN_OFFHEAP_CLASS_H_ 6 #define MEMBER_IN_OFFHEAP_CLASS_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class HeapObject : public GarbageCollected<HeapObject> { }; 12 class HeapObject : public GarbageCollected<HeapObject> { };
13 13
14 class OffHeapObject { 14 class OffHeapObject {
15 public: 15 public:
16 void Trace(Visitor*); 16 void Trace(Visitor*);
17 private: 17 private:
18 Member<HeapObject> m_obj; // Must not contain Member. 18 Member<HeapObject> m_obj; // Must not contain Member.
19 WeakMember<HeapObject> m_weak; // Must not contain WeakMember.
19 Persistent<HeapVector<Member<HeapObject> > > m_objs; // OK 20 Persistent<HeapVector<Member<HeapObject> > > m_objs; // OK
20 }; 21 };
21 22
22 class StackObject { 23 class StackObject {
23 STACK_ALLOCATED(); 24 STACK_ALLOCATED();
24 private: 25 private:
25 Member<HeapObject> m_obj; // OK 26 Member<HeapObject> m_obj; // OK
26 Member<OffHeapObject> m_memberOff; // NOT OK 27 Member<OffHeapObject> m_memberOff; // NOT OK
27 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK 28 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK
28 }; 29 };
(...skipping 10 matching lines...) Expand all
39 ALLOW_ONLY_INLINE_ALLOCATION(); 40 ALLOW_ONLY_INLINE_ALLOCATION();
40 public: 41 public:
41 void Trace(Visitor*); 42 void Trace(Visitor*);
42 private: 43 private:
43 Member<HeapObject> m_obj; // OK 44 Member<HeapObject> m_obj; // OK
44 }; 45 };
45 46
46 } 47 }
47 48
48 #endif 49 #endif
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp ('k') | tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698