[compiler] Delay allocation of code-embedded heap numbers.

[compiler] Delay allocation of code-embedded heap numbers.

Instead of allocating and embedding certain heap numbers into the code
during code assembly, emit dummies but record the allocation requests.
Later then, in Assembler::GetCode, allocate the heap numbers and patch
the code by replacing the dummies with the actual objects. The
RelocInfos for the embedded objects are already recorded correctly when
emitting the dummies.

R=jarin@chromium.org
BUG=v8:6048
Review-Url: https://codereview.chromium.org/2900683002
Cr-Commit-Position: refs/heads/master@{#45635}
Committed: https://chromium.googlesource.com/v8/v8/+/659e8f7b5cd318dd486f6853c4da47a9a8587aa6

[neis, 2017-05-22 08:07:16]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 08:07:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2017-05-22 08:07:34]

Please have a first look and let me know what you think of this approach.

[commit-bot: I haz the power, 2017-05-22 08:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:09:33]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26290)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/26200)

[Jarin, 2017-05-22 08:15:44]

On 2017/05/22 08:07:34, neis wrote:
> Please have a first look and let me know what you think of this approach.

Looks good.

[neis, 2017-05-29 14:24:54]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 14:25:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 14:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 14:29:38]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[neis, 2017-05-29 17:04:56]

On 2017/05/22 08:15:44, Jarin wrote:
> On 2017/05/22 08:07:34, neis wrote:
> > Please have a first look and let me know what you think of this approach.
> 
> Looks good.

Please have a second look. It's complete now but I'm not too happy with it.
Let's discuss tomorrow. Thanks!

[neis, 2017-05-29 17:14:43]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 17:14:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 17:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 17:45:33]

Dry run: This issue passed the CQ dry run.

[neis, 2017-05-30 13:11:08]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 13:11:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2017-05-30 13:11:23]

Ready for review now.

[commit-bot: I haz the power, 2017-05-30 13:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 13:18:27]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[neis, 2017-05-30 13:21:15]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 13:21:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 13:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 13:29:02]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[neis, 2017-05-30 15:06:46]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 15:06:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 16:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 16:15:53]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-05-31 11:55:54]

lgtm

https://codereview.chromium.org/2900683002/diff/120001/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):

https://codereview.chromium.org/2900683002/diff/120001/src/arm/assembler-arm....
src/arm/assembler-arm.h:1559: static void set_heap_number(Handle<HeapObject>
number, Address pc) {
Please add a brief description before the function.

[neis, 2017-05-31 12:06:30]

Description was changed from

==========
[compiler] Delay allocation of code-embedded heap numbers.

R=jarin@chromium.org
BUG=
==========

to

==========
[compiler] Delay allocation of code-embedded heap numbers.

R=jarin@chromium.org
BUG=v8:6048
==========

[neis, 2017-05-31 12:33:30]

Description was changed from

==========
[compiler] Delay allocation of code-embedded heap numbers.

R=jarin@chromium.org
BUG=v8:6048
==========

to

==========
[compiler] Delay allocation of code-embedded heap numbers.

Instead of allocating and embedding certain heap numbers into the code
during code assembly, emit dummies but record the allocation requests.
Later then, in Assembler::GetCode, allocate the heap numbers and patch
the code by replacing the dummies with the actual objects. The
RelocInfos for the embedded objects are already recorded correctly when
emitting the dummies.

R=jarin@chromium.org
BUG=v8:6048
==========

[neis, 2017-05-31 12:36:04]

The CQ bit was checked by neis@chromium.org

[neis, 2017-05-31 12:36:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2900683002/#ps160001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-05-31 12:36:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 12:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 12:42:55]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/42147)

[neis, 2017-05-31 12:47:47]

neis@chromium.org changed reviewers:
+ jgruber@chromium.org, mvstanton@chromium.org

[neis, 2017-05-31 12:47:48]

+mvstanton for ic, +jgruber for regexp.
Thanks.

[jgruber, 2017-05-31 12:49:41]

regexp/ lgtm

[mvstanton, 2017-05-31 12:51:52]

LGTM ic

[neis, 2017-05-31 12:52:49]

The CQ bit was checked by neis@chromium.org

[neis, 2017-05-31 12:52:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2900683002/#ps180001
(title: "Fix rebase.")

[commit-bot: I haz the power, 2017-05-31 12:52:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 14:00:12]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1496235169893610,
"parent_rev": "f70ceeae1d13a151a64cbdb39505ea46c1980db8", "commit_rev":
"659e8f7b5cd318dd486f6853c4da47a9a8587aa6"}

[commit-bot: I haz the power, 2017-05-31 14:00:21]

Description was changed from

==========
[compiler] Delay allocation of code-embedded heap numbers.

Instead of allocating and embedding certain heap numbers into the code
during code assembly, emit dummies but record the allocation requests.
Later then, in Assembler::GetCode, allocate the heap numbers and patch
the code by replacing the dummies with the actual objects. The
RelocInfos for the embedded objects are already recorded correctly when
emitting the dummies.

R=jarin@chromium.org
BUG=v8:6048
==========

to

==========
[compiler] Delay allocation of code-embedded heap numbers.

Instead of allocating and embedding certain heap numbers into the code
during code assembly, emit dummies but record the allocation requests.
Later then, in Assembler::GetCode, allocate the heap numbers and patch
the code by replacing the dummies with the actual objects. The
RelocInfos for the embedded objects are already recorded correctly when
emitting the dummies.

R=jarin@chromium.org
BUG=v8:6048

Review-Url: https://codereview.chromium.org/2900683002
Cr-Commit-Position: refs/heads/master@{#45635}
Committed:
https://chromium.googlesource.com/v8/v8/+/659e8f7b5cd318dd486f6853c4da47a9a85...
==========

[commit-bot: I haz the power, 2017-05-31 14:00:23]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/659e8f7b5cd318dd486f6853c4da47a9a85...

[neis, 2017-06-13 10:01:52]

+v8-mips-ports: Could you please help with porting this CL? (I made only the
minimal changes necessary to compile.)