src/regexp/mips64/regexp-macro-assembler-mips64.cc - Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/mips64/regexp-macro-assembler-mips64.cc

Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers. (Closed)

Patch Set: Fix rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/mips64/regexp-macro-assembler-mips64.cc

diff --git a/src/regexp/mips64/regexp-macro-assembler-mips64.cc b/src/regexp/mips64/regexp-macro-assembler-mips64.cc

index 595d6fd4de5c31c43b69071c34b0543949c3be61..22fc248cb7e084a81fc99c49e006053dabe883f0 100644

--- a/src/regexp/mips64/regexp-macro-assembler-mips64.cc

+++ b/src/regexp/mips64/regexp-macro-assembler-mips64.cc

@@ -936,7 +936,7 @@ Handle<HeapObject> RegExpMacroAssemblerMIPS::GetCode(Handle<String> source) {

}

CodeDesc code_desc;

- masm_->GetCode(&code_desc);

+ masm_->GetCode(isolate(), &code_desc);

Handle<Code> code = isolate()->factory()->NewCode(

code_desc, Code::ComputeFlags(Code::REGEXP), masm_->CodeObject());

LOG(masm_->isolate(),