Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DMC::AddCompositionMarker() to take EphemeralRange Change DocumentMarkerController::AddCompositionMarker() from taking two Positions (start and end) to taking an EphemeralRange. This matches AddTextMatchMarker() and is how we eventually want all the Add*Marker() methods to work. BUG=707867 Review-Url: https://codereview.chromium.org/2899923002 Cr-Commit-Position: refs/heads/master@{#474480} Committed: https://chromium.googlesource.com/chromium/src/+/f0115f469e06ebf49f0265ec89eee5e9220f187c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
rlanday
3 years, 7 months ago (2017-05-23 18:40:24 UTC) #6
rlanday
3 years, 7 months ago (2017-05-23 18:40:25 UTC) #7
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-24 05:23:20 UTC) #8
yosin_UTC9
lgtm Please avoid to use abbrev, DMC, in summary line. People other than us don't ...
3 years, 7 months ago (2017-05-24 09:00:04 UTC) #9
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-24 09:00:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899923002/1
3 years, 7 months ago (2017-05-24 09:00:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445980)
3 years, 7 months ago (2017-05-24 09:08:49 UTC) #14
rlanday
On 2017/05/24 at 09:00:04, yosin wrote: > lgtm > > Please avoid to use abbrev, ...
3 years, 7 months ago (2017-05-24 21:20:55 UTC) #15
rlanday
Adding tkent for third_party/WebKit/Source/core/testing/Internals.cpp
3 years, 7 months ago (2017-05-24 21:23:36 UTC) #17
tkent
lgtm
3 years, 7 months ago (2017-05-24 23:43:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899923002/1
3 years, 7 months ago (2017-05-24 23:44:29 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 23:52:51 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0115f469e06ebf49f0265ec89ee...

Powered by Google App Engine
This is Rietveld 408576698