Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index a599bc244cc220be9c5bee68ad776c046aa22b0d..438eda4becae88428f8d71acf6b9fbe3d9ba6d37 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -465,9 +465,8 @@ void InputMethodController::AddCompositionUnderlines(
continue;
GetDocument().Markers().AddCompositionMarker(
- ephemeral_line_range.StartPosition(),
- ephemeral_line_range.EndPosition(), underline.GetColor(),
- underline.Thick(), underline.BackgroundColor());
+ ephemeral_line_range, underline.GetColor(), underline.Thick(),
+ underline.BackgroundColor());
}
}
@@ -690,8 +689,7 @@ void InputMethodController::SetComposition(
if (underlines.IsEmpty()) {
GetDocument().Markers().AddCompositionMarker(
- composition_range_->StartPosition(), composition_range_->EndPosition(),
- Color::kBlack, false,
+ EphemeralRange(composition_range_), Color::kBlack, false,
LayoutTheme::GetTheme().PlatformDefaultCompositionBackgroundColor());
return;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698