third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 7e2b526ff7ea4a6685731c31760a880ce0f86b95..eb9e956095f8dd1028f55e422d98e411e55e869f 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -220,10 +220,12 @@ TEST_F(DocumentMarkerControllerTest, CompositionMarkersNotMerged) {

SetBodyInnerHTML("<div style='margin: 100px'>foo</div>");

Node* text = GetDocument().body()->firstChild()->firstChild();

GetDocument().UpdateStyleAndLayout();

- MarkerController().AddCompositionMarker(Position(text, 0), Position(text, 1),

- Color::kBlack, false, Color::kBlack);

- MarkerController().AddCompositionMarker(Position(text, 1), Position(text, 3),

- Color::kBlack, true, Color::kBlack);

+ MarkerController().AddCompositionMarker(

+ EphemeralRange(Position(text, 0), Position(text, 1)), Color::kBlack,

+ false, Color::kBlack);

+ MarkerController().AddCompositionMarker(

+ EphemeralRange(Position(text, 1), Position(text, 3)), Color::kBlack, true,

+ Color::kBlack);

EXPECT_EQ(2u, MarkerController().Markers().size());

}