Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
index 5e71a42497cf11a979fea3b59ff801262adae7b8..ef38c231dd5751a64a420d06333309c9617a0645 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
@@ -156,15 +156,14 @@ void DocumentMarkerController::AddTextMatchMarker(
// throttling algorithm. crbug.com/6819.
}
-void DocumentMarkerController::AddCompositionMarker(const Position& start,
- const Position& end,
+void DocumentMarkerController::AddCompositionMarker(const EphemeralRange& range,
Color underline_color,
bool thick,
Color background_color) {
DCHECK(!document_->NeedsLayoutTreeUpdate());
- for (TextIterator marked_text(start, end); !marked_text.AtEnd();
- marked_text.Advance()) {
+ for (TextIterator marked_text(range.StartPosition(), range.EndPosition());
+ !marked_text.AtEnd(); marked_text.Advance()) {
AddMarker(marked_text.CurrentContainer(),
new DocumentMarker(marked_text.StartOffsetInCurrentContainer(),
marked_text.EndOffsetInCurrentContainer(),

Powered by Google App Engine
This is Rietveld 408576698