third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2899923002: Change DocumentMarkerController::AddCompositionMarker() to take EphemeralRange (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 9158bdade0dbb7a800039726c17f3192f96b0118..a3ce81590715021881e4b25574953e793fb48a03 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -59,8 +59,7 @@ class CORE_EXPORT DocumentMarkerController final

DocumentMarker::MarkerType,

const String& description = g_empty_string);

void AddTextMatchMarker(const EphemeralRange&, DocumentMarker::MatchStatus);

- void AddCompositionMarker(const Position& start,

- const Position& end,

+ void AddCompositionMarker(const EphemeralRange&,

Color underline_color,

bool thick,

Color background_color);