Replace remaining ASSERT with DCHECK/_EQ as appropriate

Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
TBR=mkwst

Review-Url: https://codereview.chromium.org/2896443003
Cr-Commit-Position: refs/heads/master@{#473792}
Committed: https://chromium.googlesource.com/chromium/src/+/dc46f058031dbb3c94c9b032e1b0f54028bee885

[pilgrim_google, 2017-05-19 17:38:01]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-05-19 17:38:18]

pilgrim@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2017-05-19 17:38:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-05-19 17:52:03]

LGTM

https://codereview.chromium.org/2896443003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_css_value_keywords.py (right):

https://codereview.chromium.org/2896443003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_css_value_keywords.py:97: DCHECK(id
> 0 && id < numCSSValueKeywords);

Split the dcheck into two dchecks. The same comment for other files in this CL.

[commit-bot: I haz the power, 2017-05-19 18:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:05:25]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pilgrim_google, 2017-05-22 15:38:56]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-05-22 15:38:57]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2896443003/#ps20001
(title: "rebase, split some DCHECKs")

[commit-bot: I haz the power, 2017-05-22 15:39:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 15:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 15:47:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2017-05-22 16:42:17]

Description was changed from

==========
Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
==========

to

==========
Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
TBR=mkwst
==========

[pilgrim_google, 2017-05-22 16:42:23]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-05-22 16:42:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:11:17]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[pilgrim_google, 2017-05-22 18:55:55]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-05-22 18:55:56]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2896443003/#ps40001
(title: "fix WorkerBackingThread")

[commit-bot: I haz the power, 2017-05-22 18:56:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:37:43]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pilgrim_google, 2017-05-22 20:05:20]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-05-22 20:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2896443003/#ps60001
(title: "add DCHECK_IS_ON in NormalizeAlgorithm")

[commit-bot: I haz the power, 2017-05-22 20:05:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:37:00]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[pilgrim_google, 2017-05-22 22:25:26]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-05-22 22:25:26]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2896443003/#ps80001
(title: "actually fix WorkerBackingthread")

[commit-bot: I haz the power, 2017-05-22 22:25:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:54:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495491926264390,
"parent_rev": "f010d72f5d621e78c0a0a4ae6ba3ad22f97a920b", "commit_rev":
"dc46f058031dbb3c94c9b032e1b0f54028bee885"}

[commit-bot: I haz the power, 2017-05-23 02:54:33]

Description was changed from

==========
Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
TBR=mkwst
==========

to

==========
Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
TBR=mkwst

Review-Url: https://codereview.chromium.org/2896443003
Cr-Commit-Position: refs/heads/master@{#473792}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc46f058031dbb3c94c9b032e1b0...
==========

[commit-bot: I haz the power, 2017-05-23 02:54:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dc46f058031dbb3c94c9b032e1b0...