third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp - Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Patch Set: actually fix WorkerBackingthread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

index e67d9159ddf72823dc608e1cf3c6094783c1cd38..93b13d4bfff20c0eb7307e4219c9c11de641f3f8 100644

--- a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

+++ b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

@@ -180,7 +180,9 @@ bool LookupAlgorithmIdByName(const String& algorithm_name,

const AlgorithmNameMapping* end =

kAlgorithmNameMappings + WTF_ARRAY_LENGTH(kAlgorithmNameMappings);

- ASSERT(VerifyAlgorithmNameMappings(begin, end));

+#if DCHECK_IS_ON()

+ DCHECK(VerifyAlgorithmNameMappings(begin, end));

+#endif

const AlgorithmNameMapping* it;

if (algorithm_name.Impl()->Is8Bit())