Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
Aaron Boodman, abarth-chromium, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, blink-worker-reviews_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, darin (slow to review), dcheng, devtools-reviews_chromium.org, dglazkov+blink, dshwang, dtapuska+blinkwatch_chromium.org, falken+watch_chromium.org, haraken, horo+watch_chromium.org, jsbell, Justin Novosad, kinuko+worker_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Navid Zolghadr, pfeldman+blink_chromium.org, qsr+mojo_chromium.org, rwlbuis, shimazu+worker_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining ASSERT with DCHECK/_EQ as appropriate BUG=596760 TBR=mkwst Review-Url: https://codereview.chromium.org/2896443003 Cr-Commit-Position: refs/heads/master@{#473792} Committed: https://chromium.googlesource.com/chromium/src/+/dc46f058031dbb3c94c9b032e1b0f54028bee885

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase, split some DCHECKs #

Patch Set 3 : fix WorkerBackingThread #

Patch Set 4 : add DCHECK_IS_ON in NormalizeAlgorithm #

Patch Set 5 : actually fix WorkerBackingthread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_value_keywords.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (21 generated)
pilgrim_google
3 years, 7 months ago (2017-05-19 17:38:19 UTC) #3
haraken
LGTM https://codereview.chromium.org/2896443003/diff/1/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py File third_party/WebKit/Source/build/scripts/make_css_value_keywords.py (right): https://codereview.chromium.org/2896443003/diff/1/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py#newcode97 third_party/WebKit/Source/build/scripts/make_css_value_keywords.py:97: DCHECK(id > 0 && id < numCSSValueKeywords); Split ...
3 years, 7 months ago (2017-05-19 17:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896443003/20001
3 years, 7 months ago (2017-05-22 15:39:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/443794)
3 years, 7 months ago (2017-05-22 15:47:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896443003/20001
3 years, 7 months ago (2017-05-22 16:42:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/344544)
3 years, 7 months ago (2017-05-22 17:11:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896443003/40001
3 years, 7 months ago (2017-05-22 18:56:29 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/344598)
3 years, 7 months ago (2017-05-22 19:37:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896443003/60001
3 years, 7 months ago (2017-05-22 20:05:51 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/344725)
3 years, 7 months ago (2017-05-22 20:37:00 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896443003/80001
3 years, 7 months ago (2017-05-22 22:25:50 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 02:54:37 UTC) #33
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dc46f058031dbb3c94c9b032e1b0...

Powered by Google App Engine
This is Rietveld 408576698