third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp - Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Patch Set: actually fix WorkerBackingthread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

index 379bf3908f60ec2623c1cd36a43fd4ce570e81bf..5f75102800f1e3f33ba2b39acf8d64fd68b46d39 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

@@ -989,7 +989,7 @@ void HTMLDocumentParser::EndIfDelayed() {

}

void HTMLDocumentParser::Finish() {

- // FIXME: We should ASSERT(!m_parserStopped) here, since it does not makes

+ // FIXME: We should DCHECK(!m_parserStopped) here, since it does not makes

// sense to call any methods on DocumentParser once it's been stopped.

// However, FrameLoader::stop calls DocumentParser::finish unconditionally.