Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)
Patch Set: actually fix WorkerBackingthread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/TouchEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.cpp b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
index 846196fed56bd2384b1791970ff15fe0f021445d..7c3203f21bf89ea072a54f99613a3493e232cce0 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
@@ -366,7 +366,7 @@ void TouchEventManager::UpdateTargetAndRegionMapsForTouchStarts(
DCHECK(touch_sequence_document_->GetFrame()->View());
}
- // Ideally we'd ASSERT(!m_targetForTouchID.contains(point.id())
+ // Ideally we'd DCHECK(!m_targetForTouchID.contains(point.id())
// since we shouldn't get a touchstart for a touch that's already
// down. However EventSender allows this to be violated and there's
// some tests that take advantage of it. There may also be edge
@@ -473,7 +473,7 @@ bool TouchEventManager::ReHitTestTouchPointsIfNeeded(
all_touches_released = false;
}
if (new_touch_sequence) {
- // Ideally we'd ASSERT(!m_touchSequenceDocument) here since we should
+ // Ideally we'd DCHECK(!m_touchSequenceDocument) here since we should
// have cleared the active document when we saw the last release. But we
// have some tests that violate this, ClusterFuzz could trigger it, and
// there may be cases where the browser doesn't reliably release all

Powered by Google App Engine
This is Rietveld 408576698