VR: Loading DD controller model after GL is initialized

VR: Loading DD controller model after GL is initialized

Also, the model is only loaded in Daydream-ready devices.

BUG=723033
Review-Url: https://codereview.chromium.org/2891243002
Cr-Commit-Position: refs/heads/master@{#473219}
Committed: https://chromium.googlesource.com/chromium/src/+/fb02e40644d21597ca5394189294d3bbdf337452

[acondor_, 2017-05-19 00:04:29]

acondor@google.com changed reviewers:
+ mthiesse@chromium.org

[acondor_, 2017-05-19 00:04:29]

mthiesse, PTAL before adding e2e test.

[mthiesse, 2017-05-19 14:32:42]

https://codereview.chromium.org/2891243002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2891243002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:452:
public boolean hasDaydreamSupport() {
nit: /* package */ boolean hasDaydreamSupport()

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:606: JNIEnv* env =
base::android::AttachCurrentThread();
nit: take env as an argument, since the callsite already has a JNIEnv pointer.

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:207: FROM_HERE,
base::Bind(&VrShellGl::SetControllerModel, weak_vr_shell_gl,
You said SetControllerModel was slow too, right? Should we also post this to a
background priority taskrunner?

[acondor_, 2017-05-19 16:06:49]

https://codereview.chromium.org/2891243002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2891243002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:452:
public boolean hasDaydreamSupport() {
On 2017/05/19 14:32:42, mthiesse wrote:
> nit: /* package */ boolean hasDaydreamSupport()

Done.

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:606: JNIEnv* env =
base::android::AttachCurrentThread();
On 2017/05/19 14:32:42, mthiesse wrote:
> nit: take env as an argument, since the callsite already has a JNIEnv pointer.

Done.

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2891243002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:207: FROM_HERE,
base::Bind(&VrShellGl::SetControllerModel, weak_vr_shell_gl,
On 2017/05/19 14:32:42, mthiesse wrote:
> You said SetControllerModel was slow too, right? Should we also post this to a
> background priority taskrunner?

As discussed offline, I reduced the runtime of SetControllerModel by computing
the textures in the background task.

[mthiesse, 2017-05-19 16:22:11]

lgtm

[acondor_, 2017-05-19 16:22:28]

The CQ bit was checked by acondor@google.com

[commit-bot: I haz the power, 2017-05-19 16:23:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 17:05:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495210948755790,
"parent_rev": "08113dcd52eeeadd5ac7e4e69d3a5fea15508c6a", "commit_rev":
"fb02e40644d21597ca5394189294d3bbdf337452"}

[commit-bot: I haz the power, 2017-05-19 17:05:25]

Description was changed from

==========
VR: Loading DD controller model after GL is initialized

Also, the model is only loaded in Daydream-ready devices.

BUG=723033
==========

to

==========
VR: Loading DD controller model after GL is initialized

Also, the model is only loaded in Daydream-ready devices.

BUG=723033

Review-Url: https://codereview.chromium.org/2891243002
Cr-Commit-Position: refs/heads/master@{#473219}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb02e40644d21597ca5394189294...
==========

[commit-bot: I haz the power, 2017-05-19 17:05:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb02e40644d21597ca5394189294...